Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure before resolving and remove old API call #23834

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Configure before resolving and remove old API call #23834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/client/pythonEnvironments/base/locators/common/nativePythonFinder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ class NativeGlobalPythonFinderImpl extends DisposableBase implements NativePytho
}

public async resolve(executable: string): Promise<NativeEnvInfo> {
await this.configure();
const environment = await this.connection.sendRequest<NativeEnvInfo>('resolve', {
executable,
});
Expand Down Expand Up @@ -438,10 +439,6 @@ class NativeGlobalPythonFinderImpl extends DisposableBase implements NativePytho
async getCondaInfo(): Promise<NativeCondaInfo> {
return this.connection.sendRequest<NativeCondaInfo>('condaInfo');
}

public async find(searchPath: string): Promise<NativeEnvInfo[]> {
return this.connection.sendRequest<NativeEnvInfo[]>('find', { searchPath });
}
}

type ConfigurationOptions = {
Expand Down
Loading