Add Simplified Chinese translation of Quickopen command #240

WaiSiuKei · 2017-11-16T01:29:24Z

Add Simplified Chinese translation for Quickopen command.
Here is the screenshot:

msftclas · 2017-11-16T01:29:33Z

All CLA requirements met.

brettcannon · 2017-11-16T19:57:31Z

Thanks for the PR, @WaiSiuKei ! We will have a look at this as soon as we have the time to.

c4pt0r · 2017-11-25T08:26:25Z

Thank you！

lambdaq

Hi, native speaker here. Overall this PR is very good, here is my review for some optional suggestions.

lambdaq · 2017-11-25T13:46:34Z

package.nls.zh-cn.json

+    "python.command.python.buildWorkspaceSymbols.title": "构建工作区符号",
+    "python.command.python.runtests.title": "运行全部单元测试",
+    "python.command.python.debugtests.title": "调试全部单元测试",
+    "python.command.python.execInTerminal.title": "在终端／命令行运行 Python 文件",


在命令行运行 Python 文件

这样简洁一点。This removes the duplication of 终端／命令行 for simplicity.

lambdaq · 2017-11-25T13:47:22Z

package.nls.zh-cn.json

+    "python.command.python.runCurrentTestFile.title": "运行当前单元测试文件",
+    "python.command.python.runFailedTests.title": "运行失败的单元测试",
+    "python.command.python.execSelectionInTerminal.title": "在 Python 终端运行选定内容／行",
+    "python.command.python.execSelectionInDjangoShell.title": "在 Django Shell 运行选定内容／行",


用 Python 命令行执行选定内容

更简洁。

Removed these duplications.

lambdaq · 2017-11-25T13:48:48Z

package.nls.zh-cn.json

@@ -0,0 +1,50 @@
+{
+    "python.command.python.sortImports.title": "排序引入的模块",


对 import 进行排序

会 python 用 vscode 的都能明白什么是 import.
Python developers and vscode users can understand what import means here. No need to translate the keyword.

mozillazg · 2017-11-25T02:28:48Z

package.nls.zh-cn.json

@@ -0,0 +1,50 @@
+{
+    "python.command.python.sortImports.title": "排序引入的模块",


It's confused, how about 排序 import 语句?

mozillazg · 2017-11-25T02:33:34Z

package.nls.zh-cn.json

+    "python.command.python.sortImports.title": "排序引入的模块",
+    "python.command.python.startREPL.title": "启动 REPL",
+    "python.command.python.buildWorkspaceSymbols.title": "构建工作区符号",
+    "python.command.python.runtests.title": "运行全部单元测试",


IHMO, 全部 -> 所有 is better.

Yes, VSCode used 91 '所有' and 35 '全部', in my local branch.

mozillazg · 2017-11-25T02:35:53Z

package.nls.zh-cn.json

+    "python.command.python.selectAndRunTestFile.title": "运行单元测试文件...",
+    "python.command.python.runCurrentTestFile.title": "运行当前单元测试文件",
+    "python.command.python.runFailedTests.title": "运行失败的单元测试",
+    "python.command.python.execSelectionInTerminal.title": "在 Python 终端运行选定内容／行",


How about 在 Python 终端中运行选定内容／行?

Same as below ↓.

mozillazg · 2017-11-25T02:36:16Z

package.nls.zh-cn.json

+    "python.command.python.runCurrentTestFile.title": "运行当前单元测试文件",
+    "python.command.python.runFailedTests.title": "运行失败的单元测试",
+    "python.command.python.execSelectionInTerminal.title": "在 Python 终端运行选定内容／行",
+    "python.command.python.execSelectionInDjangoShell.title": "在 Django Shell 运行选定内容／行",


How about 在 Django Shell 中运行选定内容／行?

The '中' (means 'in') seems a little annoying, but it is widely used in the translation of VSCode, will add it.

mozillazg · 2017-11-25T02:38:29Z

package.nls.zh-cn.json

+    "python.command.python.execSelectionInTerminal.title": "在 Python 终端运行选定内容／行",
+    "python.command.python.execSelectionInDjangoShell.title": "在 Django Shell 运行选定内容／行",
+    "python.command.jupyter.runSelectionLine.title": "运行选定内容／行",
+    "python.command.jupyter.execCurrentCell.title": "运行 Cell",


How about 运行当前 Cell?

Yes, 'current' is not translated.

mozillazg · 2017-11-25T02:44:05Z

package.nls.zh-cn.json

+    "python.command.python.execSelectionInDjangoShell.title": "在 Django Shell 运行选定内容／行",
+    "python.command.jupyter.runSelectionLine.title": "运行选定内容／行",
+    "python.command.jupyter.execCurrentCell.title": "运行 Cell",
+    "python.command.jupyter.execCurrentCellAndAdvance.title": "运行 Cell 和 Advance",


Advance mean move to the next Cell.

mozillazg · 2017-11-25T06:17:07Z

package.nls.zh-cn.json

+    "python.snippet.launch.watson.label": "Python: Watson 应用",
+    "python.snippet.launch.watson.description": "调试 Watson 应用",
+    "python.snippet.launch.attach.label": "Python: 链接",
+    "python.snippet.launch.attach.description": "链接远程调试器",


attach not mean 链接.

Yes, MS translate it as '附加', https://msdn.microsoft.com/zh-cn/library/3s68z0b3.aspx

# Conflicts: # package.json

mozillazg · 2017-11-27T05:54:07Z

package.nls.zh-cn.json

+    "python.command.python.selectAndRunTestFile.title": "运行单元测试文件...",
+    "python.command.python.runCurrentTestFile.title": "运行当前单元测试文件",
+    "python.command.python.runFailedTests.title": "运行失败的单元测试",
+    "python.command.python.execSelectionInTerminal.title": "在 Python 终端中运行选定内容",


IHMO, missing Line will let this is confused.
在 Python 终端中运行选定内容 don't include Run Line in Python Terminal, because there may nothing been selected when Run Line.

Yes, there is Line in EN.

brettcannon · 2017-11-27T20:37:06Z

@DonJayamanne does the current failure have absolutely anything to do with the PR? I don't think it does.

brettcannon · 2017-11-27T20:38:05Z

Thanks @mozillazg and @lambdaq for the reviews! If you have a chance, please see the changes @WaiSiuKei made and let us know if they address your concerns.

mozillazg · 2017-11-27T23:33:05Z

package.nls.zh-cn.json

@@ -0,0 +1,50 @@
+{
+    "python.command.python.sortImports.title": "对 import 进行排序",


IHMO, 排序 import 语句 is better than 对 import 进行排序. Because all other translations of command begin with a verb, only this is exceptional.

mozillazg

@WaiSiuKei Good job! Thanks for your translation!

lambdaq

LGTM

# Conflicts: # package.json

lambdaq

Hmm, why github is not diffing this commit?

brettcannon · 2017-11-29T19:03:46Z

Thanks for the reviews @mozillazg and @lambdaq !

@WaiSiuKei we will do a review to make sure the stuff is formatting appropriately, etc. and then we should be able to merge!

brettcannon · 2017-12-04T19:30:02Z

Thanks everyone for helping make this happen!

* upstream/master: Add Simplified Chinese translation of commands (#240)

laxtiz · 2018-01-16T06:33:37Z

thanks for ur hard work.

wangzhaohe · 2018-12-17T03:04:34Z

I don't want this Chinese translation. I think input English is good. Please tell me how to remove this translation. All command is Chinese, but no English command.

请问如何取消这些自动翻译呀？输入个命令找不到，还得输入中文才行。我这里全是中文，没有对应的英文。version 2018.12.1

brettcannon · 2018-12-17T19:31:00Z

@wangzhaohe we use the locale specified by VS Code, so you will have to change your locale there and the extension will pick it up.

waisuikei added 2 commits November 16, 2017 09:23

loc: add Simpified Chinese translation for Quickopen command

42a6406

style: add white space between Chinese and English

342cef0

WaiSiuKei changed the title ~~Add Simpified Chinese translation for Quickopen command~~ Add Simplified Chinese translation for Quickopen command Nov 16, 2017

WaiSiuKei changed the title ~~Add Simplified Chinese translation for Quickopen command~~ Add Simplified Chinese translation of Quickopen command Nov 17, 2017

lambdaq suggested changes Nov 25, 2017

View reviewed changes

mozillazg suggested changes Nov 25, 2017

View reviewed changes

waisuikei added 5 commits November 27, 2017 09:47

Merge commit 'b4ba602ce67c8a6f41982610b42b21cf164f986a'

28cd6b5

# Conflicts: # package.json

Revamp as per reviews

73febf2

Fix the translation of ‘Attach debugger’

8749321

Fix the translation of ‘advance’

cc8cf6b

Missing in

47051c9

mozillazg reviewed Nov 27, 2017

View reviewed changes

Missing line

6f82527

mozillazg reviewed Nov 27, 2017

View reviewed changes

Sort imports

0a20c0f

mozillazg approved these changes Nov 28, 2017

View reviewed changes

lambdaq approved these changes Nov 28, 2017

View reviewed changes

Merge commit 'e2218b1b4a00402e777a966b0cde4fb438df52b1'

cf54531

# Conflicts: # package.json

lambdaq reviewed Nov 29, 2017

View reviewed changes

brettcannon added this to the December 2017 milestone Nov 29, 2017

brettcannon approved these changes Dec 4, 2017

View reviewed changes

brettcannon merged commit fd54970 into microsoft:master Dec 4, 2017

brettcannon mentioned this pull request Dec 7, 2017

Update README to list translations #366

Closed

brettcannon mentioned this pull request Dec 11, 2017

Document what languages the extension is translated to #392

Closed

DonJayamanne added a commit that referenced this pull request Dec 14, 2017

Merge remote-tracking branch 'upstream/master'

b2b9da9

* upstream/master: Add Simplified Chinese translation of commands (#240)

microsoft locked as resolved and limited conversation to collaborators Dec 17, 2018

		@@ -0,0 +1,50 @@
		{
		"python.command.python.sortImports.title": "排序引入的模块",

Add Simplified Chinese translation of Quickopen command #240

Add Simplified Chinese translation of Quickopen command #240

Conversation

WaiSiuKei commented Nov 16, 2017 • edited Loading

msftclas commented Nov 16, 2017 • edited Loading

brettcannon commented Nov 16, 2017

c4pt0r commented Nov 25, 2017

lambdaq left a comment

Choose a reason for hiding this comment

lambdaq Nov 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lambdaq Nov 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lambdaq Nov 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brettcannon commented Nov 27, 2017

brettcannon commented Nov 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mozillazg left a comment

Choose a reason for hiding this comment

lambdaq left a comment

Choose a reason for hiding this comment

lambdaq left a comment

Choose a reason for hiding this comment

brettcannon commented Nov 29, 2017

brettcannon commented Dec 4, 2017

laxtiz commented Jan 16, 2018

wangzhaohe commented Dec 17, 2018 • edited Loading

brettcannon commented Dec 17, 2018

WaiSiuKei commented Nov 16, 2017 •

edited

Loading

msftclas commented Nov 16, 2017 •

edited

Loading

lambdaq Nov 25, 2017 •

edited

Loading

lambdaq Nov 25, 2017 •

edited

Loading

lambdaq Nov 25, 2017 •

edited

Loading

wangzhaohe commented Dec 17, 2018 •

edited

Loading