Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native Pixi locator #24442

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add native Pixi locator #24442

merged 2 commits into from
Nov 26, 2024

Conversation

renan-r-santos
Copy link

Sister PR (needs to be merged first):

@renan-r-santos renan-r-santos mentioned this pull request Nov 13, 2024
Merged
ruben-arts
ruben-arts approved these changes Nov 14, 2024
View reviewed changes
src/client/telemetry/index.ts Outdated Show resolved Hide resolved
@karthiknadig karthiknadig self-assigned this Nov 18, 2024
@karthiknadig karthiknadig added feature-request Request for new features or functionality skip tests Updates to tests unnecessary labels Nov 18, 2024
@karthiknadig karthiknadig self-requested a review November 18, 2024 15:24
@karthiknadig
Copy link
Member

This actually might need some additional handling. If pixi isn't available this needs to fall back to conda.

@renan-r-santos
Copy link
Author

This actually might need some additional handling. If pixi isn't available this needs to fall back to conda.

I'm not sure I understand what you're suggesting here. Do you mean that if the pixi tool isn't available for VSCode to invoke, for example, when using python.terminal.activateEnvironment": true, VSCode should fallback to using conda? If so, I don't think that would work as, AFAIK, conda can't manage or activate pixi environments.

@karthiknadig
Copy link
Member

I see. It wasn't clear to me, and I assumed that pixi managed envs were also conda manageable. Then this seems ok.

@ruben-arts
Copy link

Fly-by explanation from pixi maintainer:

AFAIK, conda can't manage or activate pixi environments.

While some users might use it like that it's not a promised feature and will definitely not work with the manifest (pixi.toml). Pixi creates Conda environments, this is not to be confused with the conda tool. The conda tool can understand the pixi created Conda environment, and thus act on it but that is not a recommended workflow.

You can see this workflow as "hacky" and the extension should therefor not support it.

@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Nov 25, 2024
@karthiknadig karthiknadig merged commit 4f7165f into microsoft:main Nov 26, 2024
48 of 50 checks passed
karthiknadig pushed a commit to microsoft/python-environment-tools that referenced this pull request Dec 9, 2024
@renan-r-santos
Add Pixi locator (#172)
15124b5 
Fixes #46

I'd like to reopen the discussion about adding support for Pixi given
the community interest after the above issue was closed and to bring
feature parity with the `js` locator.
Because Pixi environments have a unique directory layout, the proposed
solution is simple enough that it doesn't need any process spawning.

Sister PR:
- microsoft/vscode-python#24442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruben-arts ruben-arts ruben-arts approved these changes

@karthiknadig karthiknadig karthiknadig approved these changes

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

@karthiknadig karthiknadig

Labels
feature-request Request for new features or functionality skip tests Updates to tests unnecessary
Projects
None yet
Milestone
November 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@renan-r-santos @karthiknadig @ruben-arts @DonJayamanne