Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure relative paths to interpreters are prefixed with './' in settings.json #2750

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Ensure relative paths to interpreters are prefixed with './' in settings.json #2750

merged 2 commits into from
Oct 2, 2018

Conversation

DonJayamanne
Copy link

For #2744

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • [n/a] Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

d3r3kk
d3r3kk approved these changes Oct 2, 2018
View reviewed changes
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine: do we need to add some comment to our launch.json to notify users of this necessity?

@DonJayamanne DonJayamanne merged commit 56f1fd1 into microsoft:master Oct 2, 2018
@DonJayamanne DonJayamanne deleted the issue2744Path branch October 2, 2018 22:45
brettcannon added a commit that referenced this pull request Oct 4, 2018
@brettcannon
Revert "Ensure relative paths to interpreters are prefixed with './' …
f73a671 
…in settings.json (#2750)"

Turns out that on Windows the added `.` gets dropped, partially negating
any benefit of having this. Reverting to keep things consistent across
operating systems.

This reverts commit 56f1fd1.
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d3r3kk d3r3kk d3r3kk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @d3r3kk