Add full path to activate for conda activate command in windows. #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
DonJayamanne
requested changes
Oct 3, 2018
There was a problem hiding this comment.
Perhaps post release we could create two separate files, one for Windows and other for Unix.
Its looking a little messy now as the code diverges more due to OS differences... Post release, or now if you feel upto it. Either way, it'll need to be split up for maintenance and testability.
src/client/common/terminal/environmentActivationProviders/condaActivationProvider.ts
Outdated
Show resolved
Hide resolved
src/client/common/terminal/environmentActivationProviders/condaActivationProvider.ts
Outdated
Show resolved
Hide resolved
src/client/common/terminal/environmentActivationProviders/condaActivationProvider.ts
Outdated
Show resolved
Hide resolved
src/client/common/terminal/environmentActivationProviders/condaActivationProvider.ts
Outdated
Show resolved
Hide resolved
src/client/common/terminal/environmentActivationProviders/condaActivationProvider.ts
Outdated
Show resolved
Hide resolved
DonJayamanne
requested changes
Oct 3, 2018
src/client/common/terminal/environmentActivationProviders/condaActivationProvider.ts
Show resolved
Hide resolved
- add unit tests for the new functionality - handle 'conda' specified as the conda path (not a abs path)
d3r3kk
force-pushed
the
2753_conda_activate_win
branch
from
4867720
to
4df2329
Compare
d3r3kk
changed the title
|
@DonJayamanne please review again. Note: Tested on powershell, pwsh, and cmd on Windows 10. Works as expected. One funny behaviour we have introduced though is the use of 'exit' commands from the terminal window. Users who use this method of closing the terminal will have to type it 3 times. |
DonJayamanne
approved these changes
Oct 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2753
Any new/changed dependencies inpackage.jsonare pinned (e.g."1.2.3", not"^1.2.3"for the specified version)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)