Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pylint message names instead of codes #3600

Merged
merged 2 commits into from
Dec 24, 2018
Merged

Conversation

RomanKornev
Copy link

For #2906

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@msftclas
Copy link

msftclas commented Dec 8, 2018

CLA assistant check
All CLA requirements met.

@d3r3kk
Copy link

d3r3kk commented Dec 8, 2018

Thanks for the PR @RomanKornev. We will review this PR and have feedback for you at minimum by the end of December.

@RomanKornev
Copy link
Author

Thanks for the super fast answer! I'm glad to contribute.

@d3r3kk
Copy link

d3r3kk commented Dec 20, 2018

Update CI

@d3r3kk d3r3kk reopened this Dec 20, 2018
@brettcannon brettcannon reopened this Dec 21, 2018
@d3r3kk
Copy link

d3r3kk commented Dec 24, 2018

Much nicer experience for everyone using pylint. I've tested this locally, and since it is passing the PR-validation checks, I'm going to accept this PR.

Thanks @RomanKornev!

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@d3r3kk d3r3kk merged commit 4f19099 into microsoft:master Dec 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants