Run python code using env variables from activated envs #3930

DonJayamanne · 2019-01-08T23:28:04Z

Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
Title summarizes what is changing
Has a news entry file (remember to thank yourself!)
Unit tests & system/integration tests are added/updated
Test plan is updated as appropriate
package-lock.json has been regenerated by running npm install (if dependencies have changed)

codecov · 2019-01-09T17:45:49Z

Codecov Report

Merging #3930 into master will increase coverage by 1%.
The diff coverage is 79%.

@@           Coverage Diff           @@
##           master   #3930    +/-   ##
=======================================
+ Coverage      54%     55%    +1%     
=======================================
  Files         323     327     +4     
  Lines       13488   13660   +172     
  Branches     2096    2119    +23     
=======================================
+ Hits         7220    7385   +165     
- Misses       5789    5790     +1     
- Partials      479     485     +6

Impacted Files	Coverage Δ
...c/client/interpreter/autoSelection/rules/system.ts	`100% <ø> (ø)`	⬆️
...ent/interpreter/locators/services/pipEnvService.ts	`80% <ø> (ø)`	⬆️
src/client/interpreter/helpers.ts	`46% <ø> (ø)`	⬆️
src/client/common/platform/fileSystem.ts	`33% <ø> (-1%)`	⬇️
src/client/common/platform/platformService.ts	`31% <ø> (-2%)`	⬇️
src/client/common/process/types.ts	`86% <ø> (ø)`	⬆️
src/client/common/process/proc.ts	`14% <0%> (+1%)`	⬆️
src/client/interpreter/interpreterService.ts	`65% <0%> (-2%)`	⬇️
src/client/interpreter/virtualEnvs/index.ts	`80% <0%> (ø)`	⬆️
src/client/unittests/common/runner.ts	`19% <0%> (ø)`	⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44165a3...2ce0659. Read the comment docs.

brettcannon

I'm a bit worried about cached information for conda environments going stale if the user installs something before the timed cache invalidation.

I'm also wondering if the parsing code of the resulting environment is more complicated than it needs to be.

And because I'm me, I wonder if some of this could have been written as a Python script. 😁

src/client/common/terminal/helper.ts

src/client/common/terminal/environmentActivationProviders/pipEnvActivationProvider.ts

src/client/common/utils/cacheUtils.ts

src/test/common/process/pythonExecutionFactory.unit.test.ts

src/test/common/terminals/environmentActivationProviders/pipEnvActivationProvider.unit.test.ts

rchiodo

src/client/common/process/pythonExecutionFactory.ts

src/client/common/utils/cacheUtils.ts

src/client/common/variables/environmentVariablesProvider.ts

src/client/interpreter/activation/service.ts

IanMatthewHuff

news/2 Fixes/3330.md

news/3 Code Health/3746.md

pythonFiles/printEnvVariables.py

* 'master' of https://github.com/DonJayamanne/pythonVSCode: Misc

Co-Authored-By: DonJayamanne <don.jayamanne@yahoo.com>

…vActivationProvider.unit.test.ts Co-Authored-By: DonJayamanne <don.jayamanne@yahoo.com>

Co-Authored-By: DonJayamanne <don.jayamanne@yahoo.com>

…e/pythonVSCode into issueCondaActivation * 'issueCondaActivation' of https://github.com/DonJayamanne/pythonVSCode: Update news/2 Fixes/3330.md Update news/3 Code Health/3746.md

DonJayamanne and others added 2 commits January 1, 2019 21:01

Misc

68a566d

Merge branch 'master' of https://github.com/DonJayamanne/pythonVSCode

eea64b7

DonJayamanne changed the title ~~WIP - Run python code using env variables from activated envs~~ Run python code using env variables from activated envs Jan 9, 2019

brettcannon suggested changes Jan 9, 2019

View reviewed changes

rchiodo approved these changes Jan 10, 2019

View reviewed changes