Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all diagnostic services do not handle the same messages more than once #4038

Merged
merged 7 commits into from
Jan 18, 2019

Conversation

DonJayamanne
Copy link

For #3502
Part 2

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [no] Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@DonJayamanne DonJayamanne changed the title Issue3502 part2 Ensure all diagnostic services do not handle the same messages more than once Jan 17, 2019
@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jan 17, 2019
@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #4038 into master will increase coverage by 14%.
The diff coverage is 67%.

@@           Coverage Diff            @@
##           master   #4038     +/-   ##
========================================
+ Coverage      66%     79%    +14%     
========================================
  Files         407     407             
  Lines       18583   18610     +27     
  Branches     2992    2996      +4     
========================================
+ Hits        12121   14581   +2460     
+ Misses       6461    4026   -2435     
- Partials        1       3      +2
Flag Coverage Δ
#Linux 68% <37%> (+16%) ⬆️
#Windows 68% <37%> (+16%) ⬆️
#macOS 68% <37%> (?)

@DonJayamanne DonJayamanne merged commit db55fa1 into microsoft:master Jan 18, 2019
@DonJayamanne DonJayamanne deleted the issue3502Part2 branch May 24, 2019 20:25
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants