Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input history was never adding dupes to the list #4258

Merged
merged 4 commits into from
Feb 4, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Feb 2, 2019

For #4255

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@rchiodo rchiodo self-assigned this Feb 2, 2019
@codecov
Copy link

codecov bot commented Feb 2, 2019

Codecov Report

Merging #4258 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4258    +/-   ##
=======================================
- Coverage      79%     79%   -<1%     
=======================================
  Files         412     412            
  Lines       19045   19045            
  Branches     3083    3083            
=======================================
- Hits        15023   15022     -1     
- Misses       4019    4020     +1     
  Partials        3       3
Flag Coverage Δ
#Linux 69% <ø> (ø) ⬆️
#Windows 69% <ø> (ø) ⬇️
#macOS 68% <ø> (ø) ⬇️

@rchiodo rchiodo merged commit 11bbf52 into master Feb 4, 2019
@rchiodo rchiodo deleted the rchiodo/fix_up_input branch February 13, 2019 15:44
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants