forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all typescript errors when compiled in strict mode #7 #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4423 +/- ##
========================================
- Coverage 58% 29% -29%
========================================
Files 369 181 -188
Lines 15953 7741 -8212
Branches 2506 1193 -1313
========================================
- Hits 9168 2196 -6972
+ Misses 6158 5528 -630
+ Partials 627 17 -610 |
karrtikr
force-pushed
the
errors7
branch
2 times, most recently
from
February 16, 2019 02:16
53338b8
to
44697f5
Compare
karrtikr
force-pushed
the
errors7
branch
2 times, most recently
from
February 28, 2019 22:48
2634258
to
39a6c01
Compare
karrtikr
commented
Mar 5, 2019
DonJayamanne
approved these changes
Mar 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #611 part 7