Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all typescript errors when compiled in strict mode #7 #4423

Merged
merged 10 commits into from
Mar 5, 2019

Conversation

karrtikr
Copy link

For #611 part 7

@karrtikr karrtikr added the no-changelog No news entry required label Feb 15, 2019
@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #4423 into master will decrease coverage by 30%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #4423     +/-   ##
========================================
- Coverage      58%     29%    -29%     
========================================
  Files         369     181    -188     
  Lines       15953    7741   -8212     
  Branches     2506    1193   -1313     
========================================
- Hits         9168    2196   -6972     
+ Misses       6158    5528    -630     
+ Partials      627      17    -610

@karrtikr karrtikr force-pushed the errors7 branch 2 times, most recently from 53338b8 to 44697f5 Compare February 16, 2019 02:16
@karrtikr karrtikr closed this Feb 17, 2019
@karrtikr karrtikr reopened this Feb 17, 2019
@karrtikr karrtikr force-pushed the errors7 branch 2 times, most recently from 2634258 to 39a6c01 Compare February 28, 2019 22:48
@karrtikr karrtikr merged commit 50aeca5 into microsoft:master Mar 5, 2019
@karrtikr karrtikr deleted the errors7 branch March 5, 2019 18:07
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants