Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to node 10 #5203

Merged
merged 9 commits into from
Apr 12, 2019
Merged

Update to node 10 #5203

merged 9 commits into from
Apr 12, 2019

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Apr 11, 2019 •
edited
Loading

For #1138

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • [n/a] Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@DonJayamanne DonJayamanne changed the title Update to node 10 WIP - Update to node 10 Apr 11, 2019
@DonJayamanne DonJayamanne changed the title WIP - Update to node 10 Update to node 10 Apr 11, 2019
@DonJayamanne DonJayamanne merged commit 48a608e into microsoft:master Apr 12, 2019
@DonJayamanne DonJayamanne mentioned this pull request Apr 15, 2019
Closed
@DonJayamanne DonJayamanne deleted the issue1138 branch May 24, 2019 20:26
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rchiodo rchiodo rchiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @rchiodo