Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unexpected trailing commas in JSON files #5443

Merged
merged 3 commits into from
Apr 24, 2019
Merged

remove unexpected trailing commas in JSON files #5443

merged 3 commits into from
Apr 24, 2019

Conversation

quarthex
Copy link

@quarthex quarthex commented Apr 24, 2019

fixes #5437 and #5439

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@msftclas
Copy link

msftclas commented Apr 24, 2019

CLA assistant check
All CLA requirements met.

@DonJayamanne DonJayamanne merged commit 730691c into microsoft:master Apr 24, 2019
DonJayamanne pushed a commit that referenced this pull request Apr 24, 2019
DonJayamanne added a commit that referenced this pull request Apr 25, 2019
* release: (25 commits)
  Bump version
  remove unexpected trailing commas in JSON files (#5443)
  Fixes to creation of json for Language Server (#5436)
  Update version of Language Server
  Update version (#5435)
  Deprecate travis (#5434)
  Upload vsix to artifacts (#5412)
  Fix the flask app name prompt for launch config. (#5409)
  Reliably end test tasks in Azure Pipelines (#5410)
  fix len error (#5421)
  Fix null cases (#5419)
  Fix sorting of number only lists (#5416)
  add news
  cleanup and functional test
  working first draft
  Fix current cell colors again (#5403)
  Fix data viewer issues (#5405)
  Update 'news' command to directly update the changelog
  Fixes to the test explorer in displaying root (#5383)
  Include pylintrc (#5369)
  ...
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension doesn't load
4 participants