Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some logging for debug #759

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Added some logging for debug #759

merged 2 commits into from
Jul 30, 2018

Conversation

itoys
Copy link
Contributor

@itoys itoys commented Jul 30, 2018

@itoys itoys requested a review from ruslan-bikkinin July 30, 2018 13:04
@codecov-io
Copy link

Codecov Report

Merging #759 into master will decrease coverage by 0.06%.
The diff coverage is 4.54%.

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
- Coverage   14.45%   14.39%   -0.07%     
==========================================
  Files          63       63              
  Lines        3244     3259      +15     
  Branches      416      416              
==========================================
  Hits          469      469              
- Misses       2775     2790      +15
Impacted Files Coverage Δ
src/extension/commandPaletteHandler.ts 0% <0%> (ø) ⬆️
src/debugger/nodeDebugWrapper.ts 2.91% <0%> (-0.06%) ⬇️
src/extension/rn-extension.ts 8.73% <12.5%> (-0.68%) ⬇️

@itoys itoys merged commit 46e2461 into master Jul 30, 2018
@itoys itoys deleted the feature/additiona-debug-logging branch July 30, 2018 13:40
ruslan-bikkinin added a commit to ruslan-bikkinin/vscode-react-native that referenced this pull request Aug 28, 2018
@ruslan-bikkinin
Revert "Added some logging for debug (microsoft#759)"
47b78a8 
This reverts commit 46e2461.
ruslan-bikkinin added a commit that referenced this pull request Aug 28, 2018
@ruslan-bikkinin
Revert to the state of v0.6.13 (#782)
634e3ec 
* Revert "FIx incorrect runArguments assignment (#779)"

This reverts commit b9fbf69.

* Revert "Update changelog (#775)"

This reverts commit 5517641.

* Revert "Remove code push images (#771)"

This reverts commit b34bce9.

* Revert "Added support for Build Multiple Versions of React Native app (#766)"

This reverts commit 3e313f6.

* Revert "Update debugging.md (#765)"

This reverts commit fcfec28.

* Revert "fix typo (#763)"

This reverts commit 4dd439f.

* merge

* Revert "Use fork instead of spawn for AppWorker (#760)"

This reverts commit 2df05fa.

* Revert "Added some logging for debug (#759)"

This reverts commit 46e2461.

* Revert "[Android] Add reading SDK location from local.properties (#754)"

This reverts commit 43e1a99.

* Revert "Fixed error while stop expo packager (#753)"

This reverts commit 77b86bf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruslan-bikkinin ruslan-bikkinin ruslan-bikkinin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itoys @codecov-io @ruslan-bikkinin