Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix URI.file() on windows, avoid that process is polyfilled #12

Merged
merged 2 commits into from
Dec 18, 2020
Merged

fix URI.file() on windows, avoid that process is polyfilled #12

merged 2 commits into from
Dec 18, 2020

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Dec 18, 2020 •
edited
Loading

Problem was that process was polyfilled.

  • switch to webpack 5 where all polyfills need to be listed
  • fix for Util.resolve for URIs with no paths
  • add uri.test.ts from the vscode repo. The test run against the webpacked code and would have detected the problem.

@aeschli aeschli requested a review from jrieken December 18, 2020 16:14
@aeschli aeschli self-assigned this Dec 18, 2020
@aeschli aeschli changed the title fix URI.fle() on windows, avoid that process is polyfilled fix URI.file() on windows, avoid that process is polyfilled Dec 18, 2020
@jrieken jrieken merged commit 72bf5fb into master Dec 18, 2020
@friederbluemle friederbluemle mentioned this pull request Dec 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrieken jrieken jrieken approved these changes

Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeschli @jrieken