Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github.com as badge provider #389

Closed
andreujuanc opened this issue Oct 2, 2019 · 16 comments · Fixed by #396
Closed

Add github.com as badge provider #389

andreujuanc opened this issue Oct 2, 2019 · 16 comments · Fixed by #396
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality
Milestone
June 2020

Comments

@andreujuanc
Copy link

Now with Github Actions having badges, we've got a new provider to add to the whitelist.
I'm removing my badges for now.
@joaomoreno
Copy link
Member

Since 84f537a there is no more whitelist. Please update to the latest vsce.

@andreujuanc
Copy link
Author

@joaomoreno Well, when i had GitHub badges it stated that it was an invalid badge.

I will try again next week and create another issue if it occurs again.

Cheers

@andreujuanc
Copy link
Author

@joaomoreno
https://code.visualstudio.com/api/working-with-extensions/publishing-extension#publishing-extensions
https://code.visualstudio.com/api/references/extension-manifest#approved-badges

All these doc articles does not reflect the fact that the badges are not whitelisted anymore.

And this part of the doc , actually states the problem I have now:
Images in README.md and CHANGELOG.md may not be SVGs unless they are from trusted badge providers.

@joaomoreno
Copy link
Member

joaomoreno commented Oct 16, 2019 •
edited
Loading

@andreujuanc Thanks for the ping.

We've actually just had a discussion yesterday in the team that this list should be brought back: #395

I will fix it asap and release a new VSCE version.

@joaomoreno
Copy link
Member

joaomoreno commented Oct 16, 2019 •
edited
Loading

@andreujuanc Can you show me an example badge from Github?

@joaomoreno joaomoreno reopened this Oct 16, 2019
@joaomoreno joaomoreno self-assigned this Oct 16, 2019
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Oct 16, 2019
@andreujuanc
Copy link
Author

Sorry for the delay @joaomoreno it was a busy day.
Here is the badge I was trying to use:

[![Actions Status](https://github.com/DigitalMolecules/vscode-servicebus-explorer/workflows/Build/badge.svg)](https://github.com/DigitalMolecules/vscode-servicebus-explorer/actions)

Thanks for reopening this, it'd be really cool to show the badge :)

@joaomoreno
Copy link
Member

We can't add that source as a trusted badge provider, since this would enable anyone to simply use any badge by simply uploading it to Github.

@joaomoreno
Copy link
Member

joaomoreno commented Oct 17, 2019 •
edited
Loading

Hm... I see that's actually the Actions badge. We might need to improve the pattern here, since we currently filter on domain only.

So we're currently blocked by the Marketplace first and then by VSCE.

cc @viradhamMS @pkuma-msft

@joaomoreno joaomoreno reopened this Oct 17, 2019
@joaomoreno joaomoreno modified the milestone: October 2019 Oct 17, 2019
ItsMajestiX added a commit to ItsMajestiX/vscode-vsce that referenced this issue Oct 17, 2019
@ItsMajestiX
add feature microsoft#389
e80056d
@ItsMajestiX ItsMajestiX mentioned this issue Oct 18, 2019
Merged
@edgardmessias edgardmessias mentioned this issue Nov 8, 2019
Merged
@JohnstonCode
Copy link

Reference to all the possible badge URLs
https://help.github.com/en/actions/automating-your-workflow-with-github-actions/configuring-a-workflow#adding-a-workflow-status-badge-to-your-repository

@JohnstonCode JohnstonCode mentioned this issue Nov 8, 2019
Closed
@joaomoreno joaomoreno mentioned this issue Nov 18, 2019
Closed
mrwest808 added a commit to viablelab/bracket-padder-vscode that referenced this issue Nov 24, 2019
@mrwest808
Remove GitHub Actions badge for now
48597b2 
See microsoft/vscode-vsce#389
@felangel
Copy link

@joaomoreno had to remove my badges as well 😞@joaomoreno do you know what security concerns warrant a whitelist? I haven't seen other package/plugin discovery platforms have this requirement.

@joaomoreno joaomoreno mentioned this issue Feb 2, 2020
Closed
@edgardmessias
Copy link

edgardmessias commented Feb 8, 2020 •
edited
Loading

A temporary solution:
Instead of
https://github.com/<:user>/<:repo>/workflows/<:workflow>/badge.svg
Use the:
https://img.shields.io/github/workflow/status/<:user>/<:repo>/<:workflow>.svg or
https://img.shields.io/github/workflow/status/<:user>/<:repo>/<:workflow>/<:branch>.svg

Example:
Build Status vs Build Status

Appending ?logo=github
https://img.shields.io/github/workflow/status/<:user>/<:repo>/<:workflow>.svg?logo=github or
https://img.shields.io/github/workflow/status/<:user>/<:repo>/<:workflow>/<:branch>.svg?logo=github
Build Status

Appending ?label=<label>
https://img.shields.io/github/workflow/status/<:user>/<:repo>/<:workflow>.svg?label=<label> or
https://img.shields.io/github/workflow/status/<:user>/<:repo>/<:workflow>/<:branch>.svg?label=<label>
Build Status, or with logo Build Status

Source: https://github.com/badges/shields/blob/c455993a4d307823a1f551955e9300cd3bc6e2c2/services/github/github-workflow-status.service.js

@edgardmessias edgardmessias mentioned this issue Feb 8, 2020
Merged
@axelson axelson mentioned this issue Feb 15, 2020
Merged
axelson added a commit to elixir-lsp/vscode-elixir-ls that referenced this issue Feb 15, 2020
@axelson
Update badge (#36)
90bb731 
Otherwise we are unable to publish a new version of the extension:
microsoft/vscode-vsce#389 (comment)

also very small elixir-ls update
auchenberg added a commit to auchenberg/vscode-browser-preview that referenced this issue Mar 23, 2020
@auchenberg
Update CI badge to fix broken VSCE build
a69fe96 
microsoft/vscode-vsce#389 (comment)
Gama11 added a commit to lix-pm/lix.vscode that referenced this issue Mar 29, 2020
@Gama11
Work around microsoft/vscode-vsce#389
2d07c47
tamuratak added a commit to tamuratak/LaTeX-Workshop that referenced this issue Mar 30, 2020
@tamuratak
Use badges on shields.io. Badges on github.com make vsce cause errors.
053f01f 
See microsoft/vscode-vsce#389.
Xanewok added a commit to rust-lang/vscode-rust that referenced this issue Apr 17, 2020
@Xanewok
Use CI badge from img.shields.io
5ba3d87 
Work around microsoft/vscode-vsce#389.
Currently, we can't use SVG shields directly from github.com, so
let's temporarily use whitelisted img.shields.io.
philnash added a commit to philnash/ngrok-for-vscode that referenced this issue May 12, 2020
@philnash
Changes GitHub Actions badge to shields.io to build the project.
a73aa6a 
See: microsoft/vscode-vsce#389
@joaomoreno joaomoreno mentioned this issue May 14, 2020
Closed
@Stanzilla
Copy link

@joaomoreno what's the long term plan here?

@joaomoreno
Copy link
Member

It's to resolve the issue. 👍 Still waiting on the upstream Marketplace implementation.

@Stanzilla
Copy link

That's not a public issue we can follow, right?

@joaomoreno
Copy link
Member

Unfortunately right, but I can tell you it's getting done!

@carmenberndt carmenberndt mentioned this issue May 28, 2020
Closed
@joaomoreno
Copy link
Member

This is finally in! Both the server side changes and VSCE changes were deployed. Starting with vsce@1.77.0, you can now use github workflow badges.

@joaomoreno joaomoreno mentioned this issue Jun 15, 2020
Closed
@joaomoreno joaomoreno added this to the June 2020 milestone Jun 15, 2020
@kieferrm kieferrm mentioned this issue Jun 15, 2020
Closed
57 tasks
@zawataki zawataki mentioned this issue Aug 10, 2020
Closed
@GitMensch GitMensch mentioned this issue Aug 11, 2020
Closed
GitMensch referenced this issue in OlegKunitsyn/gnucobol-debug Aug 11, 2020
@OlegKunitsyn
github.com SVG is restricted in ovsx
0cb59ba
@smorimoto smorimoto mentioned this issue Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
June 2020
Development

Successfully merging a pull request may close this issue.

Allow badges from Github Workflows ItsMajestiX/vscode-vsce
6 participants
@joaomoreno @Stanzilla @andreujuanc @edgardmessias @felangel @JohnstonCode