-
Notifications
You must be signed in to change notification settings - Fork 29.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
move
LanguageFeatureRequestDelays into `ILanguageFeatureDebounceSer…
…vice`, have better defaults, and adopt for code lens and inlay hints, #140557
- Loading branch information
Showing
9 changed files
with
157 additions
and
81 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
122 changes: 122 additions & 0 deletions
122
src/vs/editor/common/services/languageFeatureDebounce.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| /*--------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| * Licensed under the MIT License. See License.txt in the project root for license information. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
|
|
||
| import { doHash } from 'vs/base/common/hash'; | ||
| import { LRUCache } from 'vs/base/common/map'; | ||
| import { clamp, MovingAverage, SlidingWindowAverage } from 'vs/base/common/numbers'; | ||
| import { LanguageFeatureRegistry } from 'vs/editor/common/languages/languageFeatureRegistry'; | ||
| import { ITextModel } from 'vs/editor/common/model'; | ||
| import { registerSingleton } from 'vs/platform/instantiation/common/extensions'; | ||
| import { createDecorator } from 'vs/platform/instantiation/common/instantiation'; | ||
|
|
||
|
|
||
| export const ILanguageFeatureDebounceService = createDecorator<ILanguageFeatureDebounceService>('ILanguageFeatureDebounceService'); | ||
|
|
||
| export interface ILanguageFeatureDebounceService { | ||
|
|
||
| readonly _serviceBrand: undefined; | ||
|
|
||
| for(feature: LanguageFeatureRegistry<object>, config?: { min?: number, salt?: string }): IFeatureDebounceInformation; | ||
| } | ||
|
|
||
| export interface IFeatureDebounceInformation { | ||
| get(model: ITextModel): number; | ||
| update(model: ITextModel, value: number): number; | ||
| default(): number; | ||
| } | ||
|
|
||
| namespace IdentityHash { | ||
| const _hashes = new WeakMap<object, number>(); | ||
| let pool = 0; | ||
| export function of(obj: object): number { | ||
| let value = _hashes.get(obj); | ||
| if (value === undefined) { | ||
| value = ++pool; | ||
| _hashes.set(obj, value); | ||
| } | ||
| return value; | ||
| } | ||
| } | ||
|
|
||
| export class FeatureDebounceInformation implements IFeatureDebounceInformation { | ||
|
|
||
| private readonly _cache = new LRUCache<string, SlidingWindowAverage>(50, 0.7); | ||
|
|
||
| constructor( | ||
| private readonly _registry: LanguageFeatureRegistry<object>, | ||
| private readonly _default: () => number, | ||
| private readonly _min: number, | ||
| private readonly _max: number = Number.MAX_SAFE_INTEGER, | ||
| ) { } | ||
|
|
||
| private _key(model: ITextModel): string { | ||
| return model.id + this._registry.all(model).reduce((hashVal, obj) => doHash(IdentityHash.of(obj), hashVal), 0); | ||
| } | ||
|
|
||
| get(model: ITextModel): number { | ||
| const key = this._key(model); | ||
| const avg = this._cache.get(key); | ||
| return avg | ||
| ? clamp(avg.value, this._min, this._max) | ||
| : this.default(); | ||
| } | ||
|
|
||
| update(model: ITextModel, value: number): number { | ||
| const key = this._key(model); | ||
| let avg = this._cache.get(key); | ||
| if (!avg) { | ||
| avg = new SlidingWindowAverage(12); | ||
| this._cache.set(key, avg); | ||
| } | ||
| return clamp(avg.update(value), this._min, this._max); | ||
| } | ||
|
|
||
| private _overall(): number { | ||
| const result = new MovingAverage(); | ||
| for (const [, avg] of this._cache) { | ||
| result.update(avg.value); | ||
| } | ||
| return result.value; | ||
| } | ||
|
|
||
| default() { | ||
| const value = (this._overall() | 0) || this._default(); | ||
| return clamp(value, this._min, this._max); | ||
| } | ||
| } | ||
|
|
||
|
|
||
| export class LanguageFeatureDebounceService implements ILanguageFeatureDebounceService { | ||
|
|
||
| declare _serviceBrand: undefined; | ||
|
|
||
| private readonly _data = new Map<string, FeatureDebounceInformation>(); | ||
|
|
||
| for(feature: LanguageFeatureRegistry<object>, config?: { min?: number, key?: string }): IFeatureDebounceInformation { | ||
| const min = config?.min ?? 50; | ||
| const extra = config?.key ?? undefined; | ||
| const key = `${IdentityHash.of(feature)},${min}${extra ? ',' + extra : ''}`; | ||
| let info = this._data.get(key); | ||
| if (!info) { | ||
| info = new FeatureDebounceInformation(feature, | ||
| () => (this._overallAverage() | 0) || (min * 1.5), // default is overall default or derived from min-value | ||
| min | ||
| ); | ||
| this._data.set(key, info); | ||
| } | ||
| return info; | ||
| } | ||
|
|
||
| private _overallAverage(): number { | ||
| // Average of all language features. Not a great value but an approximation | ||
| let result = new MovingAverage(); | ||
| for (let info of this._data.values()) { | ||
| result.update(info.default()); | ||
| } | ||
| return result.value; | ||
| } | ||
| } | ||
|
|
||
| registerSingleton(ILanguageFeatureDebounceService, LanguageFeatureDebounceService, true); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.