Couldn't create new files (fix #240210) (#240338)

microsoft · Feb 11, 2025 · 1fa9d37 · 1fa9d37
1 parent 21525b0
commit 1fa9d37
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/vs/workbench/services/textfile/common/encoding.ts b/src/vs/workbench/services/textfile/common/encoding.ts
@@ -338,13 +338,17 @@ async function guessEncodingByBuffer(buffer: VSBuffer, candidateGuessEncodings?:
 		}
 	}
 
-	let guessed: { encoding: string };
+	let guessed: { encoding: string | undefined } | undefined;
 	try {
 		guessed = jschardet.detect(binaryString, candidateGuessEncodings ? { detectEncodings: candidateGuessEncodings } : undefined);
 	} catch (error) {
 		return null; // jschardet throws for unknown encodings (https://github.com/microsoft/vscode/issues/239928)
 	}
 
+	if (!guessed || !guessed.encoding) {
+		return null;
+	}
+
 	const enc = guessed.encoding.toLowerCase();
 	if (0 <= IGNORE_ENCODINGS.indexOf(enc)) {
 		return null; // see comment above why we ignore some encodings