Skip to content

Commit

Permalink
assert no RPC leakage in notebook tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jrieken committed Feb 19, 2021
1 parent 3723081 commit 61df162
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ suite('Notebook Document', function () {
const disposables: vscode.Disposable[] = [];

suiteTeardown(async function () {
// utils.assertNoRpc();
utils.assertNoRpc();
await utils.revertAllDirty();
await utils.closeAllEditors();
utils.disposeAll(disposables);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import 'mocha';
import * as assert from 'assert';
import * as vscode from 'vscode';
import { createRandomFile, asPromise, disposeAll, closeAllEditors, revertAllDirty, saveAllEditors } from '../utils';
import { createRandomFile, asPromise, disposeAll, closeAllEditors, revertAllDirty, saveAllEditors, assertNoRpc } from '../utils';

// Since `workbench.action.splitEditor` command does await properly
// Notebook editor/document events are not guaranteed to be sent to the ext host when promise resolves
Expand Down Expand Up @@ -70,6 +70,9 @@ suite('Notebook API tests', function () {
const disposables: vscode.Disposable[] = [];

suiteTeardown(async function () {

assertNoRpc();

await revertAllDirty();
await closeAllEditors();

Expand Down

0 comments on commit 61df162

Please sign in to comment.