#57418 also for builtin non-EH search

microsoft · Aug 30, 2018 · 6ba2809 · 6ba2809
1 parent bc784b6
commit 6ba2809
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/src/vs/platform/search/common/search.ts b/src/vs/platform/search/common/search.ts
@@ -238,11 +238,12 @@ export class TextSearchResult implements ITextSearchResult {
 		this.range = range;
 		if (previewOptions) {
 			const previewStart = Math.max(range.startColumn - previewOptions.leadingChars, 0);
-			const previewEnd = Math.max(previewOptions.totalChars + previewStart, range.endColumn);
+			const previewEnd = previewOptions.totalChars + previewStart;
+			const endOfMatchRangeInPreview = Math.min(previewEnd, range.endColumn - previewStart);
 
 			this.preview = {
 				text: fullLine.substring(previewStart, previewEnd),
-				match: new OneLineRange(0, range.startColumn - previewStart, range.endColumn - previewStart)
+				match: new OneLineRange(0, range.startColumn - previewStart, endOfMatchRangeInPreview)
 			};
 		} else {
 			this.preview = {

diff --git a/src/vs/platform/search/test/common/search.test.ts b/src/vs/platform/search/test/common/search.test.ts
@@ -94,4 +94,22 @@ suite('TextSearchResult', () => {
 				range: new OneLineRange(5, 30, 33)
 			});
 	});
+
+	test('truncating match', () => {
+		const previewOptions: ITextSearchPreviewOptions = {
+			leadingChars: 4,
+			maxLines: 1,
+			totalChars: 5
+		};
+
+		assert.deepEqual(
+			new TextSearchResult('foo bar', new OneLineRange(0, 4, 7), previewOptions),
+			<ITextSearchResult>{
+				preview: {
+					text: 'foo b',
+					match: new OneLineRange(0, 4, 5)
+				},
+				range: new OneLineRange(0, 4, 7)
+			});
+	});
 });