Ensure no disposables leak (#209040)

microsoft · Mar 28, 2024 · 9243c3d · 9243c3d
1 parent f62931d
commit 9243c3d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -159,7 +159,6 @@
 							"src/vs/platform/opener/test/common/opener.test.ts",
 							"src/vs/platform/registry/test/common/platform.test.ts",
 							"src/vs/platform/remote/test/common/remoteHosts.test.ts",
-							"src/vs/platform/telemetry/test/browser/1dsAppender.test.ts",
 							"src/vs/platform/workspace/test/common/workspace.test.ts",
 							"src/vs/platform/workspaces/test/electron-main/workspaces.test.ts",
 							"src/vs/workbench/api/test/browser/mainThreadConfiguration.test.ts",

diff --git a/src/vs/platform/telemetry/test/browser/1dsAppender.test.ts b/src/vs/platform/telemetry/test/browser/1dsAppender.test.ts
@@ -4,6 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 import type { ITelemetryItem, ITelemetryUnloadState } from '@microsoft/1ds-core-js';
 import * as assert from 'assert';
+import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils';
 import { OneDataSystemWebAppender } from 'vs/platform/telemetry/browser/1dsAppender';
 import { IAppInsightsCore } from 'vs/platform/telemetry/common/1dsAppender';
 
@@ -28,14 +29,17 @@ suite('AIAdapter', () => {
 	const prefix = 'prefix';
 
 
+	teardown(() => {
+		adapter.flush();
+	});
+
+	ensureNoDisposablesAreLeakedInTestSuite();
+
 	setup(() => {
 		appInsightsMock = new AppInsightsCoreMock();
 		adapter = new OneDataSystemWebAppender(false, prefix, undefined!, () => appInsightsMock);
 	});
 
-	teardown(() => {
-		adapter.flush();
-	});
 
 	test('Simple event', () => {
 		adapter.log('testEvent');