don't clone outline model and simply share marker data, #140661

microsoft · Jan 18, 2022 · ca73e74 · ca73e74
1 parent 5ce14fd
commit ca73e74
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 29 deletions.
diff --git a/src/vs/editor/contrib/documentSymbols/outlineModel.ts b/src/vs/editor/contrib/documentSymbols/outlineModel.ts
@@ -25,8 +25,6 @@ export abstract class TreeElement {
 	abstract children: Map<string, TreeElement>;
 	abstract parent: TreeElement | undefined;
 
-	abstract adopt(newParent: TreeElement): TreeElement;
-
 	remove(): void {
 		if (this.parent) {
 			this.parent.children.delete(this.id);
@@ -107,14 +105,6 @@ export class OutlineElement extends TreeElement {
 	) {
 		super();
 	}
-
-	adopt(parent: TreeElement): OutlineElement {
-		let res = new OutlineElement(this.id, parent, this.symbol);
-		for (const [key, value] of this.children) {
-			res.children.set(key, value.adopt(res));
-		}
-		return res;
-	}
 }
 
 export class OutlineGroup extends TreeElement {
@@ -130,14 +120,6 @@ export class OutlineGroup extends TreeElement {
 		super();
 	}
 
-	adopt(parent: TreeElement): OutlineGroup {
-		let res = new OutlineGroup(this.id, parent, this.label, this.order);
-		for (const [key, value] of this.children) {
-			res.children.set(key, value.adopt(res));
-		}
-		return res;
-	}
-
 	getItemEnclosingPosition(position: IPosition): OutlineElement | undefined {
 		return position ? this._getItemEnclosingPosition(position, this.children) : undefined;
 	}
@@ -287,14 +269,6 @@ export class OutlineModel extends TreeElement {
 		this.parent = undefined;
 	}
 
-	adopt(): OutlineModel {
-		let res = new OutlineModel(this.uri);
-		for (const [key, value] of this._groups) {
-			res._groups.set(key, value.adopt(res));
-		}
-		return res._compact();
-	}
-
 	private _compact(): this {
 		let count = 0;
 		for (const [key, group] of this._groups) {

diff --git a/src/vs/workbench/contrib/codeEditor/browser/outline/documentSymbolsOutline.ts b/src/vs/workbench/contrib/codeEditor/browser/outline/documentSymbolsOutline.ts
@@ -308,9 +308,6 @@ class DocumentSymbolsOutline implements IOutline<DocumentSymbolItem> {
 				}
 			}
 
-			// copy the model
-			model = model.adopt();
-
 			// feature: show markers with outline element
 			this._applyMarkersToOutline(model);
 			this._outlineDisposables.add(this._markerDecorationsService.onDidChangeMarker(textModel => {