Skip to content

Commit

Permalink
Fix errors installing extension from Welcome page (fixes #50753)
Browse files Browse the repository at this point in the history
  • Loading branch information
chrmarti committed May 30, 2018
1 parent 93f10d7 commit d33a1d8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ export class ExtensionManagementService extends Disposable implements IExtension
return this.downloadAndInstallExtensions(extensionsToInstall, operataions)
.then(
locals => this.onDidInstallExtensions(extensionsToInstall, locals, operataions, [])
.then(() => locals.filter(l => areSameExtensions({ id: getGalleryExtensionIdFromLocal(l), uuid: l.identifier.uuid }, extension.identifier)[0])),
.then(() => locals.filter(l => areSameExtensions({ id: getGalleryExtensionIdFromLocal(l), uuid: l.identifier.uuid }, extension.identifier))[0]),
errors => this.onDidInstallExtensions(extensionsToInstall, [], operataions, errors));
},
error => this.onDidInstallExtensions([extension], [], [this.getOperation(extension.identifier, installed)], [error])));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ const extensionPacks: ExtensionSuggestion[] = [
// { name: localize('welcomePage.go', "Go"), id: 'lukehoban.go' },
{ name: localize('welcomePage.php', "PHP"), id: 'felixfbecker.php-pack' },
{ name: localize('welcomePage.azure', "Azure"), title: localize('welcomePage.showAzureExtensions', "Show Azure extensions"), id: 'workbench.extensions.action.showAzureExtensions', isCommand: true },
{ name: localize('welcomePage.docker', "Docker"), id: 'PeterJausovec.vscode-docker' },
{ name: localize('welcomePage.docker', "Docker"), id: 'peterjausovec.vscode-docker' },
];

const keymapExtensions: ExtensionSuggestion[] = [
Expand Down

1 comment on commit d33a1d8

@brazenest-zz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciated! 👍

Please sign in to comment.