Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected order of fuzzy find results #103889

Closed
drew-gross opened this issue Aug 4, 2020 · 3 comments
Closed

Unexpected order of fuzzy find results #103889

drew-gross opened this issue Aug 4, 2020 · 3 comments
Labels
*as-designed Described behavior is as designed feature-request Request for new features or functionality quick-pick Quick-pick widget issues

Comments

@drew-gross
Copy link

drew-gross commented Aug 4, 2020 •
edited
Loading

Version: 1.47.3
Commit: 91899dc
Date: 2020-07-23T13:08:29.692Z (1 wk ago)
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0

Steps to Reproduce:

image

  1. Create a folder with files names managed_object.h.template and generated_types.h.template
  2. Open fuzzy find and type gt.h.template
  3. Expect generated_types.h.template to be found first, instead managed_object.h.template is found first

It's unclear whether this is intentional, and I'm not sure how fuzzy find is intended to work, but coming from Sublime Text, the current behaviour is not very intuitive to me. Sublime Text puts generated_types.h.template first.

image

Does this issue occur when all extensions are disabled?: Yes
@chrmarti chrmarti assigned bpasero and unassigned chrmarti Aug 4, 2020
@bpasero bpasero added quick-pick Quick-pick widget issues feature-request Request for new features or functionality labels Aug 12, 2020
@bpasero bpasero removed their assignment Aug 12, 2020
@bpasero
Copy link
Member

bpasero commented Aug 12, 2020

/duplicate #103889

@bpasero bpasero mentioned this issue Aug 12, 2020
Open
64 tasks
@bpasero
Copy link
Member

bpasero commented Aug 13, 2020

This is a consequence of our scorer preferring consecutive matches the longer they get. gt.h.template is having more consecutive matches on generated_types.h.template compared to managed_object.h.template.

If you leave out the dots, it will sort properly:

image

@bpasero bpasero added *as-designed Described behavior is as designed and removed *duplicate Issue identified as a duplicate of another issue(s) labels Aug 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*as-designed Described behavior is as designed feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@drew-gross @bpasero @chrmarti and others