Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbound breakpoint #106795

Closed
WymaRogerJarrett opened this issue Sep 15, 2020 · 13 comments
Closed

Unbound breakpoint #106795

WymaRogerJarrett opened this issue Sep 15, 2020 · 13 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues info-needed Issue requires more information from poster

Comments

@WymaRogerJarrett
Copy link

WymaRogerJarrett commented Sep 15, 2020

We have written the needed data into your clipboard because it was too large to send. Please paste.

Issue Type: Bug

I have been setting a breakpoint on some typescript code and launch the chrome debugger. Once chrome has loaded the breakpoint changes from solid red to grey open circle and message Unbound Breakpoint.

I have searched GitHub but there does not seem to be a fix for this issue.

VS Code version: Code - Insiders 1.50.0-insider (e13875b, 2020-09-15T05:35:57.362Z)
OS version: Windows_NT x64 10.0.19041

System Info
Item Value
CPUs AMD Ryzen 7 2700X Eight-Core Processor (16 x 3693)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.95GB (10.09GB free)
Process Argv --crash-reporter-id 637413fa-86bb-4fbe-96b9-78eed6f63d04
Screen Reader yes
VM 0%
Extensions (5)
Extension Author (truncated) Version
prettier-vscode esb 5.6.0
php-debug fel 1.13.0
php-intellisense fel 2.3.14
debugger-for-chrome msj 4.12.10
eno Wsc 2.3.18

launch.json

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
    {
        "name": "Launch Chrome - Cutting",
        "request": "launch",
        "type": "pwa-chrome",
        "url": "http://localhost/sweb/cuttingschedule",
        "webRoot": "C:/wamp/www/sweb/cuttingschedule",
        "sourceMaps": true,
        "trace": true
    },
        {
            "name": "Listen for XDebug",
            "type": "php",
            "request": "launch",
            "port": 9000
        },
        {
            "name": "Listen for SWEB XDebug",
            "type": "php",
            "request": "launch",
            "pathMappings": {
                "/var/www/html": "${workspaceFolder}",
            },
            "port": 9001
        },
        {
            "name": "Launch currently open script",
            "type": "php",
            "request": "launch",
            "program": "${file}",
            "cwd": "${fileDirname}",
            "port": 9000
        }
    ]
}

vscode-debugadapter-0.json.gz

@vscodebot
Copy link

vscodebot bot commented Sep 15, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@weinand weinand assigned connor4312 and unassigned weinand Sep 15, 2020
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Sep 15, 2020
@connor4312
Copy link
Member

In the log file you included, the only three scripts the browser loaded were:

It doesn't look like your own code is loaded in the browser. Therefore we cannot set the breakpoint and mark it with an empty circle.

@connor4312 connor4312 added the info-needed Issue requires more information from poster label Sep 15, 2020
@WymaRogerJarrett
Copy link
Author

WymaRogerJarrett commented Sep 16, 2020

Issue Type: Bug

I have re-run again, trying to set a breakpoint in my typescript code.

I can see the code and set a breakpoint using chrome's internal debugger but can not do so from visual studio code.

VS Code version: Code - Insiders 1.50.0-insider (e13875b, 2020-09-15T05:35:57.362Z)
OS version: Windows_NT x64 10.0.19041

System Info
Item Value
CPUs AMD Ryzen 7 2700X Eight-Core Processor (16 x 3693)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.95GB (7.37GB free)
Process Argv --crash-reporter-id 637413fa-86bb-4fbe-96b9-78eed6f63d04
Screen Reader yes
VM 0%
Extensions (6)
Extension Author (truncated) Version
prettier-vscode esb 5.6.0
php-debug fel 1.13.0
php-intellisense fel 2.3.14
composer ika 0.7.1
debugger-for-chrome msj 4.12.10
eno Wsc 2.3.18

vscode-debugadapter-0.json.gz

2020-09-16 16_28_44-Window

2020-09-16 16_22_30-Window

@connor4312
Copy link
Member

I notice in your logs that you're opening a new window, 22 seconds into debugging. Are you trying to debug your the sources in there? You'll need update your urlFilter to include that if, so, which you can do by setting urlFilter: '*' in your launch.json.

@WymaRogerJarrett
Copy link
Author

Adding 'urlFilter' solved the problem. Documentation about this option was not clear on this point. Nowhere that I could see did it say anything about what happens if multiple windows are opened. I have been used to the PHP debugger which does not use such an option. I had assumed wrongly that the javascript debugger worked in a similar manner.

Thank you for pointing this out. Everything is now working.

@connor4312
Copy link
Member

connor4312 commented Sep 16, 2020

I think that defaulting the urlFilter is '*' is probably okay considering that we launched the debug browser fresh for the user. Thoughts @roblourens?

@roblourens
Copy link
Member

Does that mean that it will auto attach to new tabs or windows?

@WymaRogerJarrett
Copy link
Author

That was my expectation when I used the javascript debugger.

@roblourens
Copy link
Member

I see it. Cool, it's probably fine. It could be annoying if someone is using the same browser for some other tabs that they don't want to debug, especially if those pages throw exceptions or something. But I would think that most likely they'd be using another browser/another chrome profile for that.

@roblourens
Copy link
Member

It might make sense to actually name it "auto attach" or think about how it relates to node auto attach. Also as a launch config option vs user setting.

@connor4312
Copy link
Member

Well, it's kind a matrix of both. As a user, the preference of whether or not to attach to other tabs in the debug target is a personal one. But for an app, I could know that I want to debug all of these specific urls. Which is additional configuration to conceptualize.

The exception case is annoying, but it will also be kind of apparent what happened in most cases. Probably...

I think a default of * is nice so people don't have to come to us when stuff doesn't work, as Wyma did. People whose process generally works but gives them a grain of sand in their shoe are more likely to seek an answer than people who try something, hit a brick wall, and give up.

I'll toggle it on Insiders and see if we get any complaints about it.

connor4312 added a commit to microsoft/vscode-js-debug that referenced this issue Sep 16, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@lucashfreitas
Copy link

Same bug here: Start to happen on Version: 1.49.0

@connor4312
Copy link
Member

If the solution above doesn't work for you, you likely have a different issue and should open a bug here 🙂 https://github.com/microsoft/vscode-js-debug/issues

@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

5 participants