Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode emmet SASS snippets #115839

Closed
Pabuin opened this issue Feb 5, 2021 · 7 comments
Closed

VSCode emmet SASS snippets #115839

Pabuin opened this issue Feb 5, 2021 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release emmet Emmet related issues insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken verified Verification succeeded

Comments

@Pabuin
Copy link

Pabuin commented Feb 5, 2021

  • VSCode Version: 1.5.3
  • OS Version: Debian 10.7

Steps to Reproduce:

  1. EMMET snippets in SASS files end of line - ' ; '
  2. tac --> text-align: center; (!!)

Does this issue occur when all extensions are disabled?: Yes/No

@saminton
Copy link

saminton commented Feb 5, 2021

Same comportement here, a way to revert to the old Emmet functionality would be nice. Am having other bugs with SASS files and the recent emmet updated also.

@zawys
Copy link

zawys commented Feb 5, 2021

Duplicate? #115854

@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues regression Something that used to work is now broken labels Feb 5, 2021
@rzhao271 rzhao271 added this to the February 2021 milestone Feb 5, 2021
@rzhao271
Copy link
Contributor

rzhao271 commented Feb 5, 2021

Edit: The fix should be in VS Code Insider's tomorrow.
(Previous message below)

Try this workaround:

  1. Press F1 to open the Command Palette
  2. Search for and run the command 'Preferences: Open Settings (JSON)'
  3. Paste the following into the settings file that shows up and save it:
"emmet.preferences": {
    "sass.propertyEnd": "",
    "stylus.valueSeparator": " ",
    "stylus.propertyEnd": ""
}

The issue:
I forgot to set some defaults in vscode-emmet-helper while refactoring the code 😓

@rzhao271 rzhao271 added the important Issue identified as high-priority label Feb 5, 2021
rzhao271 added a commit that referenced this issue Feb 5, 2021
@rzhao271
Copy link
Contributor

rzhao271 commented Feb 5, 2021

\closedWith 339d6dd

@rzhao271 rzhao271 added candidate Issue identified as probable candidate for fixing in the next release and removed important Issue identified as high-priority unreleased Patch has not yet been released in VS Code Insiders labels Feb 5, 2021
@lyachartem
Copy link

Edit: The fix should be in VS Code Insider's tomorrow.
(Previous message below)

Try this workaround:

1. Press F1 to open the Command Palette

2. Search for and run the command 'Preferences: Open Settings (JSON)'

3. Paste the following into the settings file that shows up and save it:
"emmet.preferences": {
    "sass.propertyEnd": "",
    "stylus.valueSeparator": " ",
    "stylus.propertyEnd": ""
}

The issue:
I forgot to set some defaults in vscode-emmet-helper while refactoring the code 😓

Thank You!

@Venegrad
Copy link

Venegrad commented Feb 9, 2021

"emmet.preferences": {
    "sass.propertyEnd": "",
    "stylus.valueSeparator": " ",
    "stylus.propertyEnd": ""
}

rzhao271 added a commit that referenced this issue Feb 9, 2021
@rzhao271 rzhao271 mentioned this issue Feb 9, 2021
rzhao271 added a commit that referenced this issue Feb 10, 2021
* Fix #115854, #115839

* Fix Emmet yarn lock
@rzhao271
Copy link
Contributor

rzhao271 commented Feb 10, 2021

Verifier:

First, install the syler.sass-indented extension for SASS support.
Then, set up a .sass document with the following content:

body {

}

Within the braces, type tac. Confirm that text-align: center shows up with no trailing semicolon.

Edit: just realized SASS documents don't need braces. Least it helped with verification.

@roblourens roblourens added the verified Verification succeeded label Feb 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release emmet Emmet related issues insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants
@roblourens @rzhao271 @Venegrad @saminton @lyachartem @Pabuin @zawys and others