Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show DAP's new "ExceptionBreakpointsFilter.description" property in a hover #116347

Closed
weinand opened this issue Feb 10, 2021 · 4 comments
Closed

Show DAP's new "ExceptionBreakpointsFilter.description" property in a hover #116347

weinand opened this issue Feb 10, 2021 · 4 comments
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2021

Comments

@weinand
Copy link
Contributor

weinand commented Feb 10, 2021 •
edited
Loading

With microsoft/debug-adapter-protocol#164 a new optional property description has become available on the ExceptionBreakpointsFilter.

This feature request asks for showing this property when hovering over an exception filter in the BREAKPOINTs view.
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 10, 2021
@weinand weinand changed the title Show DAP's new "ExceptionBreakpointsFilter.canRestart" property to enable the "Restart Frame" command Show DAP's new "ExceptionBreakpointsFilter.description" property in a hover Feb 10, 2021
@isidorn
Copy link
Contributor

isidorn commented Feb 10, 2021

Same as the other one, if you add this to Mock-debug would be great so I can try it out and add it.

@isidorn isidorn added the feature-request Request for new features or functionality label Feb 10, 2021
@isidorn isidorn added this to the February 2021 milestone Feb 10, 2021
@weinand
Copy link
Contributor Author

weinand commented Feb 10, 2021

@isidorn done. The "named exception" got a "description" attribute.

@isidorn
Copy link
Contributor

isidorn commented Feb 11, 2021

@weinand great, thanks

@isidorn isidorn added the verification-needed Verification of issue is requested label Feb 22, 2021
@isidorn
Copy link
Contributor

isidorn commented Feb 22, 2021

Adding verification needed so we get this verified in endgame.

@connor4312 connor4312 added the verified Verification succeeded label Feb 24, 2021
connor4312 added a commit to microsoft/vscode-js-debug that referenced this issue Feb 24, 2021
@connor4312
feat: add hover label for exception breakpoints
18cefab 
For microsoft/vscode#116347
@isidorn isidorn added the on-release-notes Issue/pull request mentioned in release notes label Feb 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2021
Development

No branches or pull requests
4 participants
@weinand @isidorn @connor4312 and others