Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve settings order in profiles menu #119598

Closed
chrmarti opened this issue Mar 23, 2021 · 2 comments
Closed

Preserve settings order in profiles menu #119598

chrmarti opened this issue Mar 23, 2021 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label terminal-profiles
Milestone

Comments

@chrmarti
Copy link
Collaborator

Testing #119427

Not sure how the menu is sorted (e.g., using numbers for the name will make the entry show at the top):
image

Ideally the order in the settings would be preserved.

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Mar 24, 2021
@Tyriar Tyriar added this to the March 2021 milestone Mar 24, 2021
@Tyriar Tyriar added the terminal General terminal issues that don't fall under another label label Mar 24, 2021
@Tyriar Tyriar modified the milestones: March 2021, April 2021 Mar 25, 2021
@Tyriar
Copy link
Member

Tyriar commented Mar 25, 2021

This will be a bit more work than we should do this late in the iteration. To do this we'll likely need to inspect the default, user and workspace settings given from this._extHostConfiguration.getConfigProvider()).getConfiguration() and order them that way. We could also with this information indicate which are workspace profiles in the ext host, rather than in the renderer (here).

@Tyriar
Copy link
Member

Tyriar commented Oct 11, 2021

/duplicate #130192

@Tyriar Tyriar closed this as completed Oct 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label terminal-profiles
Projects
None yet
Development

No branches or pull requests

4 participants
@Tyriar @chrmarti @meganrogge and others