Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: terminal profiles #119427

Closed
3 tasks done
meganrogge opened this issue Mar 22, 2021 · 0 comments
Closed
3 tasks done

Test: terminal profiles #119427

meganrogge opened this issue Mar 22, 2021 · 0 comments

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Mar 22, 2021

Refs #45444

Complexity: 4

Authors: @meganrogge, @Tyriar

Create Issue


The new settings terminal.integrated.profiles.<platform> were added as well as a new "quick launch" area in the terminal dropdown:

image

This feature leverages and improves the existing shell detection logic used by the Select Default Shell command, and also allows linking arguments to them to improve default behavior. This for example allows us to auto detect Cygwin since it requires arguments to be used, and to have Git Bash run with --login by default (which runs ~/.bash_profile) to match what launching an external Git bash window would do.

Profiles are contributed via user or workspace settings, workspace settings should show an opt-in notification on attempted use. The set of default quick launch profiles can be seen by auto completing the profiles setting.

Here are some other changes made as part of this work:

  • Select Default Shell is renamed Select Default Profile
  • Select Default Profile has a lightning icon which enables saving a detected profile as a quick launch profile, this will be the recommended way to create a quick launch profile in the docs
    image
  • Select Default Profile now shows arguments

Please do some exploratory testing around this feature, here's somewhere to get started:

On Windows, confirm that:

  • you see and can select New Git Bash, New Command Prompt, and New PowerShell in the terminal dropdown

  • modifying terminal.integrated.profiles.windows in user settings is reflected in the dropdown and you can select those

    set to null to remove the profile from the dropdown
    set path and args
    set source to Git Bash or PowerShell

  • modifying terminal.integrated.profiles.windows in your worksapce settings should work as well. If you have modified terminal.integrated.shell or terminal.integrated.shellArgs, you shouldn't see a prompt, but otherwise, when you select the workspace defined profile from the dropdown, you should be prompted. If you select allow, your new profile should be instantiated and made active. If you select disallow, no new profile should be created.

  • Clicking Select Default Profile shows all detected profiles and those that you've added

  • Setting showQuickLaunchWslProfiles (and waiting the 10s debounce period) displays the wsl profiles in the drop down and when you Select Default Profile (confirm the ones you have installed by typing wsl.exe -l. Note that docker-desktop and docker-desktop-data should not be displayed as they're not valid shells.

On linux/macOS:

  • you see and can select New bash, New zsh, New fish, and New tmux (if you've installed tmux) in the terminal dropdown
  • modifying terminal.integrated.profiles.linux or terminal.integrated.profiles.osx in user settings is reflected in the dropdown and you can select those

    set to null to remove the profile from the dropdown
    set path and args

  • modifying terminal.integrated.profiles.linux or terminal.integrated.profiles.osx in your worksapce settings should work as well. If you have modified terminal.integrated.shell or terminal.integrated.shellArgs, you shouldn't see a prompt, but otherwise, when you select the workspace defined profile from the dropdown, you should be prompted. If you select allow, your new profile should be instantiated and made active. If you select disallow, no new profile should be created.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants