Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not notified before using workspace terminal profile #119682

Closed
JacksonKearl opened this issue Mar 23, 2021 · 2 comments
Closed

not notified before using workspace terminal profile #119682

JacksonKearl opened this issue Mar 23, 2021 · 2 comments
Assignees
@meganrogge
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@JacksonKearl
Copy link
Contributor

Testing #119427

On Linux, when I modify a workspace's terminal.integrated.profiles.linux, I see the entry immediately usable without needing to trust the workspace or even notifying me that it is coming from a workspace:

image

I have not modified terminal.integrated.shell or terminal.integrated.shellArgs, but I think even if those are modified I should be warned before running a workspace-contributed profile.
@gjsjohnmurray
Copy link
Contributor

See also #119600

@Tyriar
Copy link
Member

Tyriar commented Mar 24, 2021

/duplicate #119600

@Tyriar Tyriar closed this as completed Mar 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Tyriar @gjsjohnmurray @JacksonKearl @meganrogge and others