Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not asked for confirmation using workspace profile #119600

Closed
chrmarti opened this issue Mar 23, 2021 · 3 comments
Closed

Not asked for confirmation using workspace profile #119600

chrmarti opened this issue Mar 23, 2021 · 3 comments
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
March 2021

Comments

@chrmarti
Copy link
Collaborator

Testing #119427

macOS Catalina

I expected there to be a confirmation dialog when opening a profile configured in the workspace settings:
image
@Tyriar
Copy link
Member

Tyriar commented Mar 23, 2021

@chrmarti you may have already opted into workspace shells previously, it shares the same mechanism as shell/shellArgs

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Mar 23, 2021
@Tyriar Tyriar added this to the March 2021 milestone Mar 23, 2021
@gjsjohnmurray gjsjohnmurray mentioned this issue Mar 23, 2021
Closed
@chrmarti
Copy link
Collaborator Author

@Tyriar I used a new user data dir. 🤔

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority terminal General terminal issues that don't fall under another label and removed info-needed Issue requires more information from poster labels Mar 24, 2021
@Tyriar
Copy link
Member

Tyriar commented Mar 24, 2021

I can repo on mac

@Tyriar Tyriar closed this as completed in f934e05 Mar 24, 2021
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Mar 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

No branches or pull requests
5 participants
@Tyriar @TylerLeonhardt @chrmarti @meganrogge and others