Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated terminal settings should have a deprecation message #122355

Closed
alexr00 opened this issue Apr 27, 2021 · 3 comments
Closed

Deprecated terminal settings should have a deprecation message #122355

alexr00 opened this issue Apr 27, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-profiles verified Verification succeeded
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Apr 27, 2021

While testing #120366, I found the profile settings confusing in relation to the old shell and shellArgs settings. I know about the shell and shellArgs settings, so of course I look at them first for guidance. Since they are now deprecated, the schema should show a message to that effect to help guide me to use the new settings correctly.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-profiles labels Apr 27, 2021
@Tyriar Tyriar added this to the April 2021 milestone Apr 27, 2021
@Tyriar Tyriar closed this as completed in d3d2d11 Apr 27, 2021
@alexr00 alexr00 added the verified Verification succeeded label Apr 29, 2021
@MoishyS
Copy link

MoishyS commented May 5, 2021

it's not clear how we should replace shellArgs with defaultProfile - can't see anything in the docs about defaultProfile.

how should I change my current setting?
"terminal.integrated.shellArgs.windows": ["-ExecutionPolicy", "Bypass"],

@Tyriar
Copy link
Member

Tyriar commented May 5, 2021

For powershell you would use either:

  "terminal.integrated.profiles.windows": {
    "PowerShell": {
      "source": "PowerShell",
      "icon": "terminal-powershell",
      "args": ["-ExecutionPolicy", "Bypass"]
    }
  }

Then set it as your default via the new dropdown next to the + button or with this setting:

"terminal.integrated.defaultProfile.windows": "PowerShell"

Created microsoft/vscode-docs#4526 to fix up the docs.

Some more info in the release notes https://code.visualstudio.com/updates/v1_56#_terminal

@MoishyS
Copy link

MoishyS commented May 10, 2021

@Tyriar defaultProfile is only working when you open the terminal from the + button - it doesn't work on the first default terminal. looks like this is related to #123188, but #123188 (comment) doesn't solve it (added "terminal.integrated.shellArgs.windows": ["-ExecutionPolicy", "Bypass"])

@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-profiles verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@Tyriar @alexr00 @MoishyS and others