Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal.integrated.defaultProfile.windows not working on startup #123188

Closed
hosseini44444 opened this issue May 6, 2021 · 5 comments · Fixed by #123729
Closed

terminal.integrated.defaultProfile.windows not working on startup #123188

hosseini44444 opened this issue May 6, 2021 · 5 comments · Fixed by #123729
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes terminal General terminal issues that don't fall under another label terminal-profiles verified Verification succeeded
Milestone

Comments

@hosseini44444
Copy link

Issue Type: Bug

Hello!

current behavior:

From when I upgraded to this version when I set the default terminal to git bash and start VScode, for less than 2 seconds it shows starting... in the terminal's drop-down menu and then opens PowerShell but after that when I add a new terminal git bash opens which is the default.

Expected behavior:

I expect git bash which I have set as my default terminal profile to be opened at startup and afterward.

VS Code version: Code 1.56.0 (cfa2e21, 2021-05-04T22:09:06.405Z)
OS version: Windows_NT x64 10.0.18363

System Info
Item Value
CPUs AMD Athlon(tm) II X2 270 Processor (2 x 3416)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: disabled_off
oop_rasterization: unavailable_off
opengl: enabled_on
rasterization: unavailable_off
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 6.00GB (2.82GB free)
Process Argv --crash-reporter-id 175e6498-4ca0-4d8a-815a-1ce71fc18411
Screen Reader no
VM 0%
Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
pythonvsnew554cf:30291488
pythontb:30283811
vspre833:30267464
pythonptprofiler:30281270
vshan820:30294714
pythondataviewer:30285071
vscus158cf:30286554
vscgsv2:30294352

@vscodebot
Copy link

vscodebot bot commented May 6, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@hosseini44444 hosseini44444 changed the title terminal.integrated.defaultProfile.windows not respected on startup terminal.integrated.defaultProfile.windows not working on startup May 6, 2021
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-profiles labels May 6, 2021
@Tyriar Tyriar added this to the May 2021 milestone May 6, 2021
@thetrompf
Copy link

thetrompf commented May 7, 2021

I have problems with this as well on linux (ubuntu 20.04 LTS), it looks like if you simply start the terminal too quickly after a vscode project is loaded, then the defaultProfile is not loaded. If I exit the first terminal and start another one, the terminal profile is correctly loaded.

Peek 2021-05-07 08-24

Which affects when a terminal is restored from a previous session which is also too quickly.

Peek 2021-05-07 08-24a

If I simply wait until most/all of my extensions are loaded and their respective indicators appear in the status bar, then the profile is correctly loaded - even on startup.

Peek 2021-05-07 08-28

@shivapoudel
Copy link

@Tyriar when we can expect the next VSCode patch release? Every time, I open VSCode default bash terminal is not opened and on Windows Powershell is opened!

@71
Copy link
Contributor

71 commented May 7, 2021

In the meantime the settings terminal.integrated.shell.{os} and terminal.integrated.shellArgs.{os}, though deprecated, work fine.

@Tyriar
Copy link
Member

Tyriar commented May 7, 2021

In the meantime the settings terminal.integrated.shell.{os} and terminal.integrated.shellArgs.{os}, though deprecated, work fine.

Yes this is a good workaround for now. It's happening because the "fallback profile" is evaluated on the extension host which takes some time to startup. I expect this to get fixed when we tackle this debt item #122534

Tyriar added a commit that referenced this issue May 7, 2021
This was referenced May 25, 2021
@Tyriar Tyriar added the on-release-notes Issue/pull request mentioned in release notes label Jun 3, 2021
@andreamah andreamah added the verified Verification succeeded label Jun 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes terminal General terminal issues that don't fall under another label terminal-profiles verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@thetrompf @Tyriar @shivapoudel @71 @meganrogge @andreamah @hosseini44444 and others