Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: quit fails to work if any window has a modal dialog opened #122630

Closed
bpasero opened this issue Apr 29, 2021 · 0 comments
Closed

macOS: quit fails to work if any window has a modal dialog opened #122630

bpasero opened this issue Apr 29, 2021 · 0 comments
Assignees
@deepak1556
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded workbench-window Window management
Milestone
May 2021

Comments

@bpasero
Copy link
Member

bpasero commented Apr 29, 2021 •
edited
Loading

Steps to Reproduce:

  1. have 2 windows open
  2. in one window bring up a modal dialog (for example File > Open...)
  3. hit Cmd+Q to quit

=> all windows that do not have a modal dialog close properly
=> the window with modal dialog stays open

If I close the dialog and try to quit, it does not work anymore.

I am struggling how to resolve this and also found this seems to be an issue in a simple hello world application but I wonder if we can install a workaround.

electron/electron#28927

PS: this only seems to reproduce on macOS, on Windows and Linux you can actually quit even with modal dialog opened.
PPS: I found this while looking at #122352 where we have a modal dialog in all windows and then clicking "Restart" does not work, seems related
@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron workbench-window Window management upstream-issue-linked This is an upstream issue that has been reported upstream labels Apr 29, 2021
@rzhao271 rzhao271 added the macos Issues with VS Code on MAC/OS X label May 4, 2021
@bpasero bpasero added this to the May 2021 milestone May 14, 2021
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label May 14, 2021
@bpasero bpasero added the verified Verification succeeded label Jun 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2021
Charles-Gagnon pushed a commit to microsoft/azuredatastudio that referenced this issue Jul 1, 2021
@deepak1556 @Charles-Gagnon
chore: bump electron@12.0.7
5f0cd77 
Fixes microsoft/vscode#62177
Fixes microsoft/vscode#122630
Fixes microsoft/vscode#118267
Charles-Gagnon pushed a commit to microsoft/azuredatastudio that referenced this issue Jul 1, 2021
@deepak1556 @Charles-Gagnon
chore: bump electron@12.0.7
8f73547 
Fixes microsoft/vscode#62177
Fixes microsoft/vscode#122630
Fixes microsoft/vscode#118267
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded workbench-window Window management
Projects
None yet
Milestone
May 2021
Development

No branches or pull requests
4 participants
@bpasero @deepak1556 @rzhao271 and others