Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After port forwarding allow to open the brower with https:// #123750

Closed
morganpizzini opened this issue May 13, 2021 · 3 comments
Closed

After port forwarding allow to open the brower with https:// #123750

morganpizzini opened this issue May 13, 2021 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan remote-explorer Remote explorer view
Milestone

Comments

@morganpizzini
Copy link

When running VSCode in container I can choose to automatically open the browser by setting the code below inside devcontainer.json

"portsAttributes": {
   "5001": {
	"label": "API port",
	"onAutoForward": "openBrowser"
   }
}

This will correctly open the browser at the address http://localhost:5001 when this port is forwarded, but my application runs on httpS://localhost:5001 and so far I manually add the S.

A possible improvement could be add a parameter

"portsAttributes": {
   "5001": {
	"label": "API port",
	"onAutoForward": "openBrowser",
        "browserUrlSsl": true
   }
}
@vscodebot
Copy link

vscodebot bot commented May 13, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@alexr00
Copy link
Member

alexr00 commented May 14, 2021

@cmbrose, since we were just talking about this, FYI: looks like we have a feature request for http vs. https with Remote Containers!

I will optimistically add this to our May iteration and we'll see if I can get it done by then.

@alexr00 alexr00 added feature-request Request for new features or functionality remote-explorer Remote explorer view labels May 14, 2021
@alexr00 alexr00 added this to the May 2021 milestone May 14, 2021
alexr00 added a commit that referenced this issue May 18, 2021
@alexr00
Copy link
Member

alexr00 commented May 18, 2021

Also adding a way to change this in the context menu:

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan remote-explorer Remote explorer view
Projects
None yet
Development

No branches or pull requests

3 participants
@morganpizzini @alexr00 and others