VS Code's maximize button doesn't trigger Snap Layouts in Windows 11

[just1a-person]

Does this issue occur when all extensions are disabled?: Yes/No

• VS Code Version: 1.57.1
• OS Version: Microsoft Windows [Version 10.0.22000.51]

Steps to Reproduce:

1. Open VS Code in Windows 11 with above mentioned build.
2. Hover over the maximize button

Snap Layouts doesn't get triggered because VS Code is using a custom title bar

[sbatten]

@deepak1556 if electron adopts the windows controls overlay and I adopt it in the titlebar, we could handle this I think

[deepak1556]

Depends on electron/electron#29600

[Navpan18]

Snap layout is working when I switched my title bar type from custom to native in vs code

[esimkowitz]

Any update on this issue now that the upstream electron issue is merged and released circa electron v13?

[sbatten]

While the upstream branch was merged, the implementation of window-controls-overlay on Windows still has issues. e.g. a persistent bottom border, the icons do not match system icons on Windows 11, and the color is not dynamically settable.

[yume-chan]

@sbatten The bottom border was reported in electron/electron#31025.

The background color can be changed dynamically by set titlebarOverlay.color to transparent and put a div underneath it.

The symbol (_□×) color truly can't be changed dynamically, and Electron doesn't correctly draw hover color for transparent buttons now

[401-Unauthorized]

In VS code on Windows 11 snap layouts

Works normally with - "window.titleBarStyle": "native"
Does not work with - "window.titleBarStyle": "custom"

Refer to:
https://docs.microsoft.com/en-us/windows/apps/desktop/modernize/apply-snap-layout-menu

[zhiyong-ft]

@401-Unauthorized This worked on my setup.

[nonintanon]

@401-Unauthorized thanks! it works.

[JorisWijgert]

Also, if you still prefer to use the custom title bar style, you can also use Win + Z to open the Snap Layouts

[sanamhub]

Yes, I was going to create this issue, eventually I find it here while searching for duplicate

[yume-chan]

Electron 18 now supports dynamically changing title bar color: electron/electron#33440

Still blocked on #145527