chore: update to electron 18

[deepak1556]

Fixes #144962
Refs #146584
Fixes #108509

[VitalyAnkh]

Electron 18.0.1 has been released, so this PR could use electron 18.0.1 instead.

[deepak1556]

It will be updated when corresponding internal builds are available.

[fisforfaheem]

Electron 18.2.0 is stable enough

[mkurz]

Please bump to electron 19.0.1 straight. Electron 19 switched to Chromium 102 which contains an important fix to make it run on Linux on Apples M1 chips, see: https://github.com/AsahiLinux/docs/wiki/Broken-Software
Would be awesome if you could make that happen, thank you!

[deepak1556]

@mkurz can you point to the upstream bug that addresses the issue ? We can try backporting the fix to Electron 18 if it is possible.

Just to give some context on Electron version adoption for VSCode, we currently follow an 8 week stabilization cycle, the first 4 weeks we have our nightly exploration builds that is largely self-hosted by our team and then we have an endgame testing using these builds. Once we are confident with exploration builds the update would then be pushed to insiders in the following iteration for wider testing from the VSCode community and it may or may not be pushed to stable depending on the data we acquire from insiders testing. Since we have already spent time stabilizing Electron 18 for exploration builds this iteration, a jump to Electron 19 at this point would only delay the next update adoption. On the other hand, once Electron 18 is promoted to insiders we can actively look into adopting Electron 19 for exploration builds.

[mkurz]

can you point to the upstream bug that addresses the issue ? We can try backporting the fix to Electron 18 if it is possible.

https://bugs.chromium.org/p/chromium/issues/detail?id=1301788
Thanks! If not possible to backport it's still ok to just wait, at least it will arrive at some point (other projects seem to be stuck with old electron versions and never update...)

[deepak1556]

Change has been backported at electron/electron#34385

[mkurz]

Thanks @deepak1556!

[bpasero]

👏