Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send feedback dialog doesn't provide correct affordances #12926

Closed
mousetraps opened this issue Sep 28, 2016 · 4 comments
Closed

Send feedback dialog doesn't provide correct affordances #12926

mousetraps opened this issue Sep 28, 2016 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities ux User experience issues verified Verification succeeded
Milestone

Comments

@mousetraps
Copy link
Contributor

Testing #12519

Hyperlinks should be underlined when hovering in Other ways to contact us box
image

Wrong cursor when hovering over tweet button, and also button should look depressed (physically, not emotionally)
image

Similar to #12847, the selection cursor is appearing for unselectable text
image

Additionally, we should consider outlining the dialog itself to better differentiate from the background
image

@joaomoreno joaomoreno self-assigned this Sep 28, 2016
@joaomoreno joaomoreno added this to the Backlog milestone Sep 28, 2016
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities ux User experience issues labels Sep 28, 2016
@joaomoreno
Copy link
Member

This would make a great PR!

@bpasero bpasero added the good first issue Issues identified as good for first-time contributors label Sep 29, 2016
@bpasero
Copy link
Member

bpasero commented Sep 29, 2016

The tweet button is disabled, thats why the cursor looks like that. You need to type text to make it different.

@wprater
Copy link
Contributor

wprater commented Oct 17, 2016

FYI, Im only seeing the href underline issues on current insiders build. I have a quick PR to fix that, however, when does the feedback face showup?

@bpasero
Copy link
Member

bpasero commented Oct 18, 2016

@wprater you need to patch the product.json a little bit to make it show:

Add:

"sendASmile": {
        "reportIssueUrl": "https://go.microsoft.com/fwlink/?LinkId=534872",
        "requestFeatureUrl": "https://go.microsoft.com/fwlink/?LinkID=533482"
    },
"requestFeatureUrl": "https://go.microsoft.com/fwlink/?LinkID=533482",
    "reportIssueUrl": "https://go.microsoft.com/fwlink/?LinkId=534872"

wprater added a commit to wprater/vscode that referenced this issue Oct 18, 2016
@bpasero bpasero modified the milestones: October 2016, Backlog Oct 18, 2016
@bpasero bpasero closed this as completed Oct 18, 2016
@mousetraps mousetraps added the verified Verification succeeded label Oct 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities ux User experience issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants