When the command longer than 1023 runInTerminal fail

[chianquan]

Does this issue occur when all extensions are disabled?: Yes/No
The bug is found when use extensions,so I can't disable all extensions.

• VS Code Version:1.60.2 (Universal)
• OS Version: Darwin x64 20.2.0

Steps to Reproduce:

1. use vscode-js-debug plugin
2. make env PATH logger enough to cause target command longer than 1023 .
3. run js debug. It will halt when the debug plugin first send runInTerminal request.the terminal leave over an command length 1023(It seems cut by something.)

[roblourens]

This sounds familiar... do you know what the issue is here @connor4312?

[connor4312]

Sounds familiar to, but I don't see any open issue for it and can readily reproduce it.

Issue in core so assigning to the both of us 🙂

[roblourens]

I'm pretty sure we are sending the right text to the terminal via sendText, but it's a little weird, it goes away when I am debugging. Do you know @Tyriar?

Once I got text missing from the middle instead of just a truncated command /Users/roblou/.nvm/versions/node/v16.4.0/bin/node: invalid value for NODE_OPTIONS (unterminated string)

[connor4312]

I can verify the right text is being sent here:

vscode/src/vs/workbench/api/node/extHostDebugService.ts

Line 137 in b6a2e69

terminal.sendText(command);

I can also repro by making an extension that simply does:

const term = vscode.window.createTerminal();
term.show();
term.sendText(`echo "${'hello world'.repeat(500)}" | wc -c`)

So this seems like a terminal issue

[Tyriar]

/duplicate #127699