Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Disabling explorer Undo/Redo #141351

Closed
2 tasks done
JacksonKearl opened this issue Jan 25, 2022 · 0 comments
Closed
2 tasks done

Test: Disabling explorer Undo/Redo #141351

JacksonKearl opened this issue Jan 25, 2022 · 0 comments

Comments

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Jan 25, 2022

Refs: #117621

Complexity: 3

Create Issue


There's a new setting explorer.enableUndo which controls how the explorer interacts with Cmd+Z. Verify:

  • When warn (default), all destructive undos in the explorer are guarded by a prompt. This includes dragging a file into the explorer then undoing, pasting a folder/file and undoing, or whatever other actions you can think of.
  • When allow, the behaviour of the existing stable is maintained. Generally, this tries to warn when the destruction would be less-expected (for instance if the next item in the undo stack is a file creation, but the current Undo context isn't the explorer). The main thing to verify here is that behaviour hasn't changed since stable.
  • When neverdisable, the explorer never participates in Undo operations, and undos will be routed to the DOM/editor even when focus is in the explorer.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants