Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer still prompts for undo operation even with explorer.undo set to never #141557

Closed
stevencl opened this issue Jan 26, 2022 · 5 comments
Closed
Assignees
Labels
*as-designed Described behavior is as designed bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues

Comments

@stevencl
Copy link
Member

Testing #141351
I set explorer.undo to never but still get prompted when I try to undo a file creation action from the explorer.
Recording 2022-01-26 at 12 44 22

@JacksonKearl
Copy link
Contributor

Sorry about that, I provided a faulty description. The real setting is: "explorer.enableUndo": "disable", and it should be a registered setting.

@stevencl
Copy link
Member Author

stevencl commented Jan 28, 2022

I tried to set enableUndo to disable but I got an error message saying that a boolean was expected. I tried setting it to false and to disable but I still see the prompt.

@JacksonKearl JacksonKearl added the verification-found Issue verification failed label Jan 28, 2022
@JacksonKearl JacksonKearl added this to the January 2022 milestone Jan 28, 2022
@JacksonKearl JacksonKearl added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues and removed verification-found Issue verification failed labels Jan 28, 2022
@JacksonKearl
Copy link
Contributor

Ah, this is a good catch, thanks.

Turns out that once explorer undo is disabled, the undo ends up being handled by the active editor. In your case, that editor was the same resource that the explorer undo would have handled, so the behaviour was the same, despite the explorer not actually participating in the undo... the fix for this is trickier.

Pushing this out as the original issue is mainly for prompting and disabling undo in "unexpected" circumstances, if the editor is open there is at least some amount of expectation.

@JacksonKearl JacksonKearl added the *as-designed Described behavior is as designed label Feb 21, 2022
@JacksonKearl JacksonKearl removed this from the February 2022 milestone Feb 21, 2022
@JacksonKearl
Copy link
Contributor

Closing as-designed because the UNDO isn't handled by explorer, and more importantly this only applies to empty files where the data-loss risk is negligible.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues
Projects
None yet
Development

No branches or pull requests

3 participants
@stevencl @JacksonKearl and others