Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Flow: Close the loop between committing and creating a PR #151589

Closed
joaomoreno opened this issue Jun 9, 2022 · 2 comments
Closed

PR Flow: Close the loop between committing and creating a PR #151589

joaomoreno opened this issue Jun 9, 2022 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality git GIT issues on-testplan plan-item VS Code - planned item for upcoming
Milestone

Comments

@joaomoreno
Copy link
Member

For our selfhosting PR flow purposes, today VS Code will automatically commit in a brand new randomly named branch, if the user's sitting on main. But there's still manual work required to go from there to having a PR created.

One suggestion would be to leverage the git.postCommitCommand setting and have GHPRI participate in there.

@alexr00 has suggested the following experience: it would be ideal if, right after committing something which caused VS Code to generate and switch to a new branch, the PR creation view would pop up, so ideally all the user has to do is click Create PR.

@joaomoreno joaomoreno added feature-request Request for new features or functionality git GIT issues labels Jun 9, 2022
@joaomoreno joaomoreno added this to the June 2022 milestone Jun 9, 2022
@joaomoreno joaomoreno added the plan-item VS Code - planned item for upcoming label Jun 9, 2022
@lszomoru
Copy link
Member

The running idea is to create a commit action button to which the PR extension would contribute a command:

image

Since we are running out of time this milestone, this work will happen next milestone.

@lszomoru lszomoru modified the milestones: June 2022, July 2022 Jun 23, 2022
alexr00 added a commit to microsoft/vscode-pull-request-github that referenced this issue Jul 13, 2022
alexr00 added a commit to microsoft/vscode-pull-request-github that referenced this issue Jul 13, 2022
* Post create command work in progress

* Add git post commit command provider
Part of microsoft/vscode#151589
@lszomoru
Copy link
Member

Git extension API is in place, and the GHPR extension now contributes a post-commit command:

image

@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality git GIT issues on-testplan plan-item VS Code - planned item for upcoming
Projects
None yet
Development

No branches or pull requests

3 participants