should the commit button be hidden when there are no staged changes?

[meganrogge]

Testing #153317
I noticed this bc the button made me think that I had forgotten to commit changes I had staged

[jcezarms]

At first I thought greying out the button would be a more consistent approach, but this could both be made unintuitive accessibility- and theme-wise, so hiding until staging is done is best.

[lszomoru]

One thing to keep in mind is that depending on user settings one can commit changes that are not yet staged. Next milestone I will take a look at the various settings and I will factor in the settings value in the logic that displays the commit action button.

[heartacker]

this would address
#135992 (comment)

👍

[lszomoru]

@meganrogge, could you please share the following user settings:

• git.enableSmartCommit
• git.suggestSmartCommit
• git.smartCommitChanges

[meganrogge]

Not sure what they were when i encountered this (probably whatever is specified in the TPI), but they're currently

1. false
2. true
3. all

[lszomoru]

Thanks! The TPI does not mention any of the smart commit settings so I will assume that the state of these settings was the same. Even though you have git.enableSmartCommit disabled, do you have git.suggestSmartCommit which means that in your screenshot above, the "Commit" button is the right button to display. If you were to click on in, you will see the smart commit dialog showing you the various options that you have.

If both git.enableSmartCommit and git.suggestSmartCommit are disabled, given the state in your screenshot, the correct button to show would be "Sync Changes" as clicking "Commit" is not actionable given your settings. These improvements will be included in the Insiders released soon.

[lszomoru]

The git.enableSmartCommit, git.suggestSmartCommit, and git.smartCommitChanges settings are now factored in when deciding whether to enable/disable the "Commit" action button. The "Commit" action button will show as enabled in case one of the following commands is true:

• git.enableSmartCommit === true && git.smartCommitChanges === 'all'
• git.enableSmartCommit === true && git.smartCommitChanges === 'tracked' && stagedChanges > 0
• git.enableSmartCommit === false && git.suggestSmartCommit === true

[heartacker]

@lszomoru could it be hide entirely(not just disable) when git.enableSmartCommit === false && git.suggestSmartCommit === false

and show them when there are staged files

[lszomoru]

@heartacker, I will continue to monitor customer feedback and will adjust the behaviour accordingly.