Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Git Commit action button + smart commit #156182

Closed
2 tasks done
lszomoru opened this issue Jul 25, 2022 · 0 comments
Closed
2 tasks done

Test: Git Commit action button + smart commit #156182

lszomoru opened this issue Jul 25, 2022 · 0 comments

Comments

@lszomoru
Copy link
Member

lszomoru commented Jul 25, 2022

Refs: #153707

Complexity: 2

Create Issue


Based on user feedback, this milestone we have improved the logic determining the enablement of the "Commit" action button. We are now using the git.enableSmartCommit, git.suggestSmartCommit, and git.smartCommitChanges to determine whether the button should be enabled/disabled.

Prerequisites

Start VS Code Insiders and ensure that the following settings are set to their default values:

  • scm.showActionButton is set to true
  • git.showActionButton is set to true, true, true
  • git.postCommitCommand is set to none

Test Plan

  • Start VS Code Insiders
  • Open a folder/workspace that contains a git repository
  • Ensure that the following settings are set:
    • git.enableSmartCommit: false
    • git.suggestSmartCommit: true
  • Make a change to a file and switch to the "Source Control" view
    • Confirm that the modified file appears in the list of changed files
    • Confirm that the "Commit" button is enabled
  • Set the git.suggestSmartCommit setting to false
    • Confirm that the "Commit" button is disabled
  • Click the + action for the file so that it gets staged
    • Confirm that the "Commit" button is enabled
  • Click the - action for the file so that it gets un-staged
  • Set the git.enableSmartCommit setting to true
    • Confirm that the "Commit" button is enabled
@lszomoru lszomoru added this to the July 2022 milestone Jul 25, 2022
@ghost ghost assigned daviddossett and benibenj Jul 26, 2022
@benibenj benibenj removed their assignment Jul 26, 2022
@daviddossett daviddossett removed their assignment Jul 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants