Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove SimpleFindWidget type option #154158

Closed
meganrogge opened this issue Jul 5, 2022 · 4 comments
Closed

remove SimpleFindWidget type option #154158

meganrogge opened this issue Jul 5, 2022 · 4 comments
Assignees
@Tyriar @meganrogge
Labels
debt Code quality issues terminal-find Relating the terminal's find widget
Milestone
Backlog

Comments

@meganrogge
Copy link
Contributor

And instead pass in (or don't) a new option for the type

af1152f#r77652553
@meganrogge meganrogge added debt Code quality issues terminal-find Relating the terminal's find widget labels Jul 5, 2022
@meganrogge meganrogge self-assigned this Jul 5, 2022
@meganrogge meganrogge added this to the July 2022 milestone Jul 5, 2022
meganrogge referenced this issue Jul 5, 2022
@meganrogge
improve consistency of terminal find with editor find (#148306)
af1152f
@meganrogge
Copy link
Contributor Author

so the complexity here is that we can't reference the keybinding service within the super call to the SimpleFindWidget constructor and need to do that to provide the options to the find input object that's read only.

@meganrogge
Copy link
Contributor Author

the alternative would be to pass in the options from both the terminal view and terminal editor (redundant)

@meganrogge
Copy link
Contributor Author

going to pass in an options object and handle the keybinding in simple find widget

@Tyriar Tyriar modified the milestones: July 2022, Backlog Jul 11, 2022
@meganrogge meganrogge mentioned this issue Aug 14, 2022
Closed
@meganrogge
Copy link
Contributor Author

Spent awhile on this, don't think we will get to it

@meganrogge meganrogge closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
debt Code quality issues terminal-find Relating the terminal's find widget
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge