Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft layer breaker: Terminal should not be mentioned in SimpleFindWidget #158014

Closed
Tyriar opened this issue Aug 12, 2022 · 2 comments
Closed

Soft layer breaker: Terminal should not be mentioned in SimpleFindWidget #158014

Tyriar opened this issue Aug 12, 2022 · 2 comments
Assignees
@Tyriar @meganrogge
Labels
debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s) terminal-find Relating the terminal's find widget
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 12, 2022

Spotted while exploring #156179

vscode/src/vs/workbench/contrib/codeEditor/browser/find/simpleFindWidget.ts

Lines 83 to 85 in eaa6485

appendCaseSensitiveLabel: options.appendCaseSensitiveLabel && options.type === 'Terminal' ? this._getKeybinding(TerminalCommandId.ToggleFindCaseSensitive) : undefined,
appendRegexLabel: options.appendRegexLabel && options.type === 'Terminal' ? this._getKeybinding(TerminalCommandId.ToggleFindRegex) : undefined,
appendWholeWordsLabel: options.appendWholeWordsLabel && options.type === 'Terminal' ? this._getKeybinding(TerminalCommandId.ToggleFindWholeWord) : undefined,

@Tyriar Tyriar added debt Code quality issues terminal-find Relating the terminal's find widget labels Aug 12, 2022
@Tyriar Tyriar added this to the Backlog milestone Aug 12, 2022
@meganrogge
Copy link
Contributor

/duplicate #154158

@VSCodeTriageBot VSCodeTriageBot added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 14, 2022
@VSCodeTriageBot
Copy link
Collaborator

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s) terminal-find Relating the terminal's find widget
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@Tyriar @meganrogge @VSCodeTriageBot