Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar can overflow when tabbing through entries #154708

Closed
donald-ning opened this issue Jul 10, 2022 · 9 comments · Fixed by #155649
Closed

Status bar can overflow when tabbing through entries #154708

donald-ning opened this issue Jul 10, 2022 · 9 comments · Fixed by #155649
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded workbench-status Status bar
Milestone

Comments

@donald-ning
Copy link

donald-ning commented Jul 10, 2022

Does this issue occur when all extensions are disabled?: No

  • VS Code Version:1.69.0
  • OS Version:MacOS M1

Steps to Reproduce:

  1. I found that in vscode's navigation bar, if the content is outside the scope of the presentation and arrow keys are used, the following image appears.
  2. bug
@dbaeumer
Copy link
Member

@donald-ning can you please describe what you would expect to see.

@donald-ning
Copy link
Author

donald-ning commented Jul 13, 2022

I think the navigation at the bottom is out of place, isn't that a bad design? I want to be able to scroll, not clutter,
In addition, after this happens, the window cannot be moved. It can only be removed by closing the software and opening it again.

@alexdima alexdima assigned bpasero and unassigned alexdima Jul 13, 2022
@bpasero
Copy link
Member

bpasero commented Jul 13, 2022

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@bpasero bpasero added the info-needed Issue requires more information from poster label Jul 13, 2022
@donald-ning
Copy link
Author

For the preview version, I use the same method and it will still look like this.
Snipaste_2022-07-15_15-10-11

@bpasero
Copy link
Member

bpasero commented Jul 15, 2022

I am curious what contents are there for you in the status bar, because I will probably have a hard time to reproduce. Can you follow these steps in the video and paste the contents here?
Recording 2022-07-15 at 11 06 12

@bpasero bpasero changed the title The interface disorder Status bar overflows Jul 15, 2022
@donald-ning
Copy link
Author

I'm sorry, I'm just a beginner, I don't know the specific code content. I can only give you my specific operation in this case.

2022-07-15.20.22.35.mov

@bpasero bpasero added the workbench-status Status bar label Jul 15, 2022
@bpasero
Copy link
Member

bpasero commented Jul 15, 2022

Yeah I can reproduce but I do not have a good idea how to solve this. #84258 is related to use a different strategy and clip the entry instead of hiding it.

In general we miss a good overflow strategy for the status bar (related #6651).

Is there someone with energy to investigate a solution? Maybe in CSS?

@bpasero bpasero changed the title Status bar overflows Status bar can overflow when tabbing through entries Jul 15, 2022
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues and removed info-needed Issue requires more information from poster accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jul 15, 2022
@bpasero bpasero added this to the Backlog milestone Jul 15, 2022
@bpasero bpasero added the layout General VS Code workbench layout issues label Jul 15, 2022
@nirabhromakhal
Copy link
Contributor

Hi, what if the status bar becomes scrollable when it overflows, but no scrollbar is displayed? We can then scroll horizontally using the mouse wheel or using the left/right arrow keys.

Will this be a good enough solution? I can try to implement this with minimal changes.

vscode.status.bar.overflow.mp4

@bpasero
Copy link
Member

bpasero commented Jul 18, 2022

Yeah if we can somehow do this only when keyboard focus is in I am willing to take any solution that does not result in the multi line layout shift 👍

Thanks!

@bpasero bpasero modified the milestones: Backlog, July 2022 Jul 20, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 22, 2022
@alexr00 alexr00 added the verified Verification succeeded label Jul 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded workbench-status Status bar
Projects
None yet
7 participants