Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed an issue where status bar items can overflow #155585

Closed
wants to merge 0 commits into from

Conversation

nirabhromakhal
Copy link
Contributor

This PR fixes #154708
I made the status bar scrollable and allowed horizontal scrolling of the status bar using mouse wheel or left/right arrow keys.

@bpasero bpasero self-assigned this Jul 19, 2022
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but looking at this change made me realise that the simplest solution is to simply set overflow: hidden to the status bar. I am not entirely sure we want the scrolling to be honest, just because that may break existing experiences.

The reason overflow: visible was added in the first place seems to be b8a75a3 and I think we would need a solution that sets overflow: visible only when there is a beak.

@bpasero bpasero added this to the July 2022 milestone Jul 19, 2022
@nirabhromakhal
Copy link
Contributor Author

nirabhromakhal commented Jul 19, 2022

Hi,
I have a question regarding this. What if somebody clicks on the notification 'bell', and then decreases the vscode window width? What will happen to the beak? Will it still be shown when the 'bell' is hidden?

@nirabhromakhal
Copy link
Contributor Author

nirabhromakhal commented Jul 19, 2022

I think we would need a solution that sets overflow: visible only when there is a beak.

Let us suppose that there is a beak, and overflow is set to visible. Now if we decrease the window width, then the status bar items will overflow again.

This is one of the only solutions I could think of where the beak has position: absolute but relative to the entire window, so even with overflow: hidden set for the status bar, the beak is still displayed on top of everything when the bell is clicked.

status.bar.fix.with.beak.mp4

@bpasero
Copy link
Member

bpasero commented Jul 19, 2022

Yeah I think it would be fine to still show the beak even if the notification bell drops. Can you push those changes and I can review?

@nirabhromakhal
Copy link
Contributor Author

I'm sorry I didn't realize force pushing will close the pull request. Anyway I created a new PR without the old commit.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status bar can overflow when tabbing through entries
3 participants