Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer newly created breakpoints until initialize request is received #1702

Closed
weinand opened this issue Dec 29, 2015 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Dec 29, 2015

A debug adapter is free to request persisted breakpoints at any time by sending an "initialize" request. If another breakpoint is created before the "initialize" request has arrived, the breakpoint is directly sent to the adapter without waiting for the "initialize" request. This is a bug. We should buffer these breakpoints and send them to the adapter only upon receipt of the "initialize".

cc @felixfbecker

@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Dec 29, 2015
@weinand weinand added this to the Jan 2016 milestone Dec 29, 2015
@roslanr18
Copy link

.

@isidorn isidorn closed this as completed in 7398515 Jan 4, 2016
@isidorn isidorn assigned weinand and unassigned isidorn Jan 4, 2016
@weinand weinand added the verified Verification succeeded label Jan 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants