Extension not updating after having it installed from the terminal using --install-Extension

[dbaeumer]

• VSCode Version: 1.9.0-insiders
• OS Version: Windows

Steps to Reproduce:

1. I installed the eslint extension using the command line as described here: [feature request] lint file with extension other than *.js vscode-eslint#42 (comment). The vsix is in that comment as well.
2. Now I published a new version to the store with version number 1.2.1 expecting that the eslint will be updated to that version. However no update happens in the insider build into which I installed eslint using the command line.

[bpasero]

Adding @sandy081 since @joaomoreno is out on vac.

[sandy081]

Looks like showing updates for locally installed extensions was never working. The only way for now to update such extensions is

• Search for that extension and Install it from market place

When syncing installed extensions with gallery extensions we are using id as mapper which is available only for extensions installed from gallery.

Fix is to use identifier publisher_id.extension_name which maps any installed extension with gallery

[sandy081]

@joaomoreno FYI

[dbaeumer]

@sandy081 @egamma would this be a candidate?

[joaomoreno]

@dbaeumer This is neither a candidate nor important. It's barely a bug. It's a feature we never supported. In order to benefit from its updates, you must install an extension from the gallery. Installing a VSIX is an extraordinary, exceptional, out-of-normal situation. At least this is our current story.

An argument which supports this is the fact that anyone can just come up with the same publisher and extension names as the ones in the store for their VSIX. We don't want to have situations in which we overwrite something we should not.

@sandy081 I suggest to revert this change.

[sandy081]

This is definitely not a candidate (hence set to January). But IMO, this looks to me a bug from an end user point of view. In this scenario, As an user, I expect an extension to show update or to distinguish local (VSIX) with Gallery extension. I would not suggest to have another category of extensions instead it makes much sense to get it sync with market place.

If disagreed, I will revert the fix

[dbaeumer]

I look onto this form a user perspective. Since the market place is not allowing us to have an insider channel I ask ESLint extension users to install the vsix to help me testing new features. However now all users that did this are stuck and they don't even know about this since I didn't know about this. They are not receiving an new updates anymore

@joaomoreno if this is working 'as-designed' could you please let me know how I should ask existing ESLint extension users to participate in new version testing.

[joaomoreno]

@dbaeumer Not supported, but tracked: #15756. If we want it badly, I believe we should support it from the Marketplace.

@sandy081 I can't be sure that this change won't break existing users, since we now may be matching against some extensions that the user has installed locally and he didn't intend to.

[sandy081]

Fix reverted

[joaomoreno]

Closing as duplicate of #15756

[sandy081]

Let's fix this for February.

[sandy081]

@joaomoreno Pushed the reverted fix.

[aeschli]

Verified, but found #21375