Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes TypeScript Inlay Hints Are Off #190953

Closed
hediet opened this issue Aug 22, 2023 · 5 comments · Fixed by #200036
Closed

Sometimes TypeScript Inlay Hints Are Off #190953

hediet opened this issue Aug 22, 2023 · 5 comments · Fixed by #200036
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug inlay-hints insiders-released Patch has been released in VS Code Insiders papercut 🩸 A particularly annoying issue impacting someone on the team verified Verification succeeded

Comments

@hediet
Copy link
Member

hediet commented Aug 22, 2023

Sometimes inlay hints are off for a short amount of time:

Image

It happens randomly and fixes itself quickly:

Image

I cannot reproduce it in isolation or in the monaco editor playground, but I see it very often when working in the VS Code repo.

I think this is what happens:

  • I type somewhere to trigger a delayed update
  • I wait until the delay completes and the provider is asked
  • I add new lines
  • The provider comes back, but does not consider the edits in between
  • The inlay hints are off

I'm not sure if this is an issue of the inlay hints feature or typescripts implementation.

@hediet hediet added the papercut 🩸 A particularly annoying issue impacting someone on the team label Aug 22, 2023
@jrieken
Copy link
Member

jrieken commented Dec 4, 2023

/duplicate of #145377

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 4, 2023
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
@hediet
Copy link
Member Author

hediet commented Dec 5, 2023

Image

I still do think is buggy behavior and not a problem of delays.
The initial screenshot should not be observed, regardless of delays.

I'm not sure though if this is a typescript bug or inlay hint bug.

And I can still reproduce it by doing random edits (took me some minutes though):

Image

@hediet hediet reopened this Dec 5, 2023
@jrieken jrieken closed this as completed Dec 5, 2023
@jrieken
Copy link
Member

jrieken commented Dec 5, 2023

@hediet this is still a duplicate of #145377

@hediet hediet reopened this Dec 5, 2023
@hediet hediet mentioned this issue Dec 5, 2023
hediet added a commit that referenced this issue Dec 5, 2023
@hediet
Copy link
Member Author

hediet commented Dec 5, 2023

Repro steps:

  • Open Monaco Editor
  • Wait for 4 seconds, notice the inlay hint afer 1
  • Press enter in line 1
  • Wait for 1 second
  • Press enter in line 1 every 100 ms
  • Notice that after 3 seconds there are invalid inline suggestions

Image

Validation:

  • In the playground, click on "Compare with latest dev"
  • Verify that there are no invalid inline suggestions after doing the steps again

@hediet hediet removed the *duplicate Issue identified as a duplicate of another issue(s) label Dec 5, 2023
@hediet hediet added this to the December 2023 milestone Dec 5, 2023
hediet added a commit that referenced this issue Dec 5, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jan 22, 2024
@hediet hediet added the verified Verification succeeded label Jan 24, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug inlay-hints insiders-released Patch has been released in VS Code Insiders papercut 🩸 A particularly annoying issue impacting someone on the team verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants